Bug 2242910

Summary:	The "Review details" page of the "Run Job" REX wizard shows values from hidden fields
Product:	Red Hat Satellite	Reporter:	Odilon Sousa <osousa>
Component:	Remote Execution	Assignee:	Adam Ruzicka <aruzicka>
Status:	CLOSED ERRATA	QA Contact:	Peter Ondrejka <pondrejk>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.13.0	CC:	ahumbe, aruzicka, lhellebr, pcreech, rlavi
Target Milestone:	6.13.6	Keywords:	Regression, Triaged, UserExperience
Target Release:	Unused
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-foreman_remote_execution-8.3.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	2220969	Environment:
Last Closed:	2023-11-21 21:27:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Odilon Sousa 2023-10-09 17:41:18 UTC

+++ This bug was initially created as a clone of Bug #2220969 +++

Created attachment 1974333 [details]
example job template with hidden field box checked

Description of problem:

When the input for a job template has the "Hidden Value" checkmark box checked, that value is still displayed in the "Review details" page of the "Run job" wizard (used to run remote execution jobs).

This doesn't happen when using the legacy form.


Version-Release number of selected component (if applicable):

Satellite 6.13


How reproducible:

100%


Steps to Reproduce:
1.  create a job template with an input field, and check the "hidden value" check-mark box
2.  browse to hosts > all hosts, click the check-mark box next to a host and choose the menu option "schedule remote job"
3.  proceed through the "Run job" wizard
4.  observe the "Review details" page in the "Run job" wizard

Actual results:

The contents of the input field marked with the "Hidden Value" check-mark box appears in the "Review details" page.


Expected results:

The contents of the input field marked with the "Hidden Value" check-mark box should be replaced with asterixes in the "Review details" page.

Additional info:

This doesn't seem to happen in the legacy form (just click the "Use legacy form" link in the upper-right corner of the "Run job" page), and the contents of the hidden field don't seem to appear under Monitor > Jobs.

--- Additional comment from  on 2023-07-06T18:14:24Z 

Created attachment 1974334 [details]
review details page showing the contents of the input field that was supposed to be hidden

--- Additional comment from  on 2023-07-18T08:09:00Z 

Created redmine issue https://projects.theforeman.org/issues/36602 from this bug

--- Additional comment from  on 2023-07-21T08:27:34Z 

Verified with Sat 6.14.0 snap 8.0.

In the last step of (re-)scheduling a job, there are now hidden inputs asterisked-out.

An unnecessary "feature" that poses a slight security risk is the fact that the number of asterisks matches the number of characters in the hidden value. This is understandable in the password-type field where it is a browser thing but unnecessary in the review form where an arbitrary number of asterisks could have been used. Nevertheless, this is not a security regression since both the old form and input step of the new form do this.

Comment 2 Peter Ondrejka 2023-10-30 12:42:42 UTC

Verified on Satellite 6.13.6 snap 1, the values marked as hidden are replaced with asterisks on the review page

Comment 8 errata-xmlrpc 2023-11-21 21:27:35 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Satellite 6.13.6 Async Update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:7461