Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2220969 - The "Review details" page of the "Run Job" REX wizard shows values from hidden fields
Summary: The "Review details" page of the "Run Job" REX wizard shows values from hidde...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Remote Execution
Version: 6.13.0
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: 6.14.0
Assignee: Adam Ruzicka
QA Contact: Lukáš Hellebrandt
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-07-06 18:13 UTC by Jessica Richards
Modified: 2023-11-08 14:20 UTC (History)
5 users (show)

Fixed In Version: rubygem-foreman_remote_execution-10.0.4
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 2242910 (view as bug list)
Environment:
Last Closed: 2023-11-08 14:19:54 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
example job template with hidden field box checked (51.81 KB, image/png)
2023-07-06 18:13 UTC, Jessica Richards 		no flags Details
review details page showing the contents of the input field that was supposed to be hidden (68.88 KB, image/png)
2023-07-06 18:14 UTC, Jessica Richards 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 36602 0 Normal Ready For Testing The "Review details" page of the "Run Job" REX wizard shows values from hidden fields 2023-07-18 08:57:42 UTC
Red Hat Issue Tracker SAT-18857 0 None None None 2023-07-10 12:26:32 UTC
Red Hat Product Errata RHSA-2023:6818 0 None None None 2023-11-08 14:20:08 UTC

Description Jessica Richards 2023-07-06 18:13:25 UTC 
Created attachment 1974333 [details]
example job template with hidden field box checked

Description of problem:

When the input for a job template has the "Hidden Value" checkmark box checked, that value is still displayed in the "Review details" page of the "Run job" wizard (used to run remote execution jobs).

This doesn't happen when using the legacy form.


Version-Release number of selected component (if applicable):

Satellite 6.13


How reproducible:

100%


Steps to Reproduce:
1.  create a job template with an input field, and check the "hidden value" check-mark box
2.  browse to hosts > all hosts, click the check-mark box next to a host and choose the menu option "schedule remote job"
3.  proceed through the "Run job" wizard
4.  observe the "Review details" page in the "Run job" wizard

Actual results:

The contents of the input field marked with the "Hidden Value" check-mark box appears in the "Review details" page.


Expected results:

The contents of the input field marked with the "Hidden Value" check-mark box should be replaced with asterixes in the "Review details" page.

Additional info:

This doesn't seem to happen in the legacy form (just click the "Use legacy form" link in the upper-right corner of the "Run job" page), and the contents of the hidden field don't seem to appear under Monitor > Jobs.
Comment 1 Jessica Richards 2023-07-06 18:14:24 UTC 
Created attachment 1974334 [details]
review details page showing the contents of the input field that was supposed to be hidden
Comment 2 Adam Ruzicka 2023-07-18 08:09:00 UTC 
Created redmine issue https://projects.theforeman.org/issues/36602 from this bug
Comment 3 Lukáš Hellebrandt 2023-07-21 08:27:34 UTC 
Verified with Sat 6.14.0 snap 8.0.

In the last step of (re-)scheduling a job, there are now hidden inputs asterisked-out.

An unnecessary "feature" that poses a slight security risk is the fact that the number of asterisks matches the number of characters in the hidden value. This is understandable in the password-type field where it is a browser thing but unnecessary in the review form where an arbitrary number of asterisks could have been used. Nevertheless, this is not a security regression since both the old form and input step of the new form do this.
Comment 6 errata-xmlrpc 2023-11-08 14:19:54 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.14 security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6818
Note You need to log in before you can comment on or make changes to this bug.