Bug 2243746
| Summary: | Review Request: rust-clap-num - Number parsers for clap | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedora.dm0 |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/clap-num | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-10-19 20:01:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2243788 | ||
|
Description
fedora.dm0
2023-10-12 21:01:13 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6521033 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243746-rust-clap-num/fedora-rawhide-x86_64/06521033-rust-clap-num/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > I wasn't sure if it was preferable to change flags or skip the test.
Modifying compiler flags is a last resort.
For tests that fail because we run them in release mode instead of debug mode, skipping them is usually the best solution.
Though I wonder if we could modify the "%cargo_test" macro to run tests with debug assertions ...
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === I recommend using something like this instead of overriding compiler flags: """ %cargo_test -- -- --skip basic::min_max_debug_assert """ This way of skipping tests is officially supported and will keep working, whereas overriding compiler flags is a more brittle and unsupported solution that might break in the future. === I would appreciate it if you could review one of my pending packages in return. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap-num FEDORA-2023-e0182cda94 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e0182cda94 FEDORA-2023-e0182cda94 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |