Bug 2243746 - Review Request: rust-clap-num - Number parsers for clap
Summary: Review Request: rust-clap-num - Number parsers for clap
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/clap-num
Whiteboard:
Depends On:
Blocks: 2243788
TreeView+ depends on / blocked
 
Reported: 2023-10-12 21:01 UTC by fedora.dm0
Modified: 2023-10-19 20:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-10-19 20:01:11 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description fedora.dm0 2023-10-12 21:01:13 UTC
Spec URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-clap-num.spec
SRPM URL: https://github.com/dm0-/copr-firecracker/raw/fedora/rust-clap-num-1.0.2-1.fc38.src.rpm
Description: Number parsers for clap
Fedora Account System Username: dm0

This crate is a dependency of firecracker-1.5.

The spec was automatically generated except for one line adding -Cdebug-assertions for a test that expects a panic.  I wasn't sure if it was preferable to change flags or skip the test.

Comment 1 Fedora Review Service 2023-10-12 21:08:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6521033
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2243746-rust-clap-num/fedora-rawhide-x86_64/06521033-rust-clap-num/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-10-13 22:33:24 UTC
> I wasn't sure if it was preferable to change flags or skip the test.

Modifying compiler flags is a last resort.
For tests that fail because we run them in release mode instead of debug mode, skipping them is usually the best solution.
Though I wonder if we could modify the "%cargo_test" macro to run tests with debug assertions ...

Comment 3 Fabio Valentini 2023-10-18 09:32:22 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

I recommend using something like this instead of overriding compiler flags:

"""
%cargo_test -- -- --skip basic::min_max_debug_assert
"""

This way of skipping tests is officially supported and will keep working, whereas overriding compiler flags is a more brittle and unsupported solution that might break in the future.


===

I would appreciate it if you could review one of my pending packages in return.

Comment 4 Fedora Admin user for bugzilla script actions 2023-10-19 19:30:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clap-num

Comment 5 Fedora Update System 2023-10-19 19:57:58 UTC
FEDORA-2023-e0182cda94 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e0182cda94

Comment 6 Fedora Update System 2023-10-19 20:01:11 UTC
FEDORA-2023-e0182cda94 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.