Bug 2244126

Summary: Review Request: ardour8 - Digital Audio Workstation
Product: [Fedora] Fedora Reporter: Nils Philippsen <nphilipp>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mads, ngompa13, nphilipp, package-review, upstream-release-monitoring
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://ardour.org
Whiteboard:
Fixed In Version: ardour8-8.1.0-1.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-21 15:06:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
The .spec file difference from Copr build 6524392 to 6528081
none
The .spec file difference from Copr build 6528081 to 6552397 none

Description Nils Philippsen 2023-10-13 21:57:32 UTC
Spec URL: https://nphilipp.fedorapeople.org/review/ardour8/1/ardour8.spec
SRPM URL: https://nphilipp.fedorapeople.org/review/ardour8/1/ardour8-8.0.0-1.fc40.src.rpm
Description: Ardour is a multi-channel digital audio workstation, allowing users to record, edit, mix and master audio and MIDI projects. It is targeted at audio engineers, musicians, soundtrack editors and composers.
Fedora Account System Username: nphilipp

Comment 1 Nils Philippsen 2023-10-13 22:12:58 UTC
NB: As with previous major releases of Ardour, the reason for having a separate package for this new version is to give users the option to stay with the old version for existing projects in order to preserve workflows – the new version 8 introduces many new features involving changes of the UI and removes some old functionality. Please refer to the upstream release notes for details: https://ardour.org/whatsnew.html

Comment 2 Nils Philippsen 2023-10-13 22:28:27 UTC
*** Bug 2242774 has been marked as a duplicate of this bug. ***

Comment 3 Fedora Review Service 2023-10-13 23:33:22 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6524392
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244126-ardour8/fedora-rawhide-x86_64/06524392-ardour8/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Nils Philippsen 2023-10-15 13:27:31 UTC
Spec URL: https://nphilipp.fedorapeople.org/review/ardour8/2/ardour8.spec
SRPM URL: https://nphilipp.fedorapeople.org/review/ardour8/2/ardour8-8.0.0-1.fc40.src.rpm

This updates the specifies the license in SPDX format. Also, the spec file uses rpmautospec and the original spec file (above) was the processed version of it, tripping a couple of warnings in fedora-review/rpmlint, oops. This one is the unprocessed version (the spec file contains the processed one because that’s what `fedpkg srpm` does).

Comment 5 Fedora Review Service 2023-10-15 16:52:44 UTC
Created attachment 1994093 [details]
The .spec file difference from Copr build 6524392 to 6528081

Comment 6 Fedora Review Service 2023-10-15 16:52:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6528081
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244126-ardour8/fedora-rawhide-x86_64/06528081-ardour8/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Nils Philippsen 2023-10-21 00:01:47 UTC
Spec URL: https://nphilipp.fedorapeople.org/review/ardour8/3/ardour8.spec
SRPM URL: https://nphilipp.fedorapeople.org/review/ardour8/3/ardour8-8.1.0-1.fc40.src.rpm

Ardour was updated to version 8.1.0 in the meantime.

Comment 8 Fedora Review Service 2023-10-21 01:22:21 UTC
Created attachment 1994914 [details]
The .spec file difference from Copr build 6528081 to 6552397

Comment 9 Fedora Review Service 2023-10-21 01:22:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6552397
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244126-ardour8/fedora-rawhide-x86_64/06552397-ardour8/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Neal Gompa 2023-10-21 12:33:54 UTC
This package looks pretty reasonable and similar enough to ardour7.

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 11 Nils Philippsen 2023-10-21 12:51:28 UTC
Thanks for the review!

Comment 12 Fedora Admin user for bugzilla script actions 2023-10-21 12:57:14 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/ardour8