Spec URL: https://nphilipp.fedorapeople.org/review/ardour8/1/ardour8.spec SRPM URL: https://nphilipp.fedorapeople.org/review/ardour8/1/ardour8-8.0.0-1.fc40.src.rpm Description: Ardour is a multi-channel digital audio workstation, allowing users to record, edit, mix and master audio and MIDI projects. It is targeted at audio engineers, musicians, soundtrack editors and composers. Fedora Account System Username: nphilipp
NB: As with previous major releases of Ardour, the reason for having a separate package for this new version is to give users the option to stay with the old version for existing projects in order to preserve workflows – the new version 8 introduces many new features involving changes of the UI and removes some old functionality. Please refer to the upstream release notes for details: https://ardour.org/whatsnew.html
*** Bug 2242774 has been marked as a duplicate of this bug. ***
Copr build: https://copr.fedorainfracloud.org/coprs/build/6524392 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244126-ardour8/fedora-rawhide-x86_64/06524392-ardour8/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://nphilipp.fedorapeople.org/review/ardour8/2/ardour8.spec SRPM URL: https://nphilipp.fedorapeople.org/review/ardour8/2/ardour8-8.0.0-1.fc40.src.rpm This updates the specifies the license in SPDX format. Also, the spec file uses rpmautospec and the original spec file (above) was the processed version of it, tripping a couple of warnings in fedora-review/rpmlint, oops. This one is the unprocessed version (the spec file contains the processed one because that’s what `fedpkg srpm` does).
Created attachment 1994093 [details] The .spec file difference from Copr build 6524392 to 6528081
Copr build: https://copr.fedorainfracloud.org/coprs/build/6528081 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244126-ardour8/fedora-rawhide-x86_64/06528081-ardour8/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://nphilipp.fedorapeople.org/review/ardour8/3/ardour8.spec SRPM URL: https://nphilipp.fedorapeople.org/review/ardour8/3/ardour8-8.1.0-1.fc40.src.rpm Ardour was updated to version 8.1.0 in the meantime.
Created attachment 1994914 [details] The .spec file difference from Copr build 6528081 to 6552397
Copr build: https://copr.fedorainfracloud.org/coprs/build/6552397 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244126-ardour8/fedora-rawhide-x86_64/06552397-ardour8/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This package looks pretty reasonable and similar enough to ardour7. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
Thanks for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/ardour8