Bug 2244463
| Summary: | Review Request: rubygem-faraday-net_http - Faraday adapter for Net::HTTP | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Benson Muite <benson_muite> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, vondruch |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-11-18 18:23:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2244212 | ||
| Bug Blocks: | |||
|
Description
Benson Muite
2023-10-16 14:28:06 UTC
I would suggest to close this request. The ruby2_keywords is part of Ruby StdLib: https://src.fedoraproject.org/rpms/ruby/blob/1f35109c5e7f5df5b51708cc46150b0f4949229a/f/ruby.spec#_1331 Unfortunately, it is not explicitly provided by the `rubygem(ruby2_keywords)` provide. Apart of this being new(ish) feature, it would also be better if this feature was not used, because it basically explicitly says that the specific code uses some deprecated Ruby feature. BTW probably the best workaround ATM is remove the explicitly generated require: https://src.fedoraproject.org/rpms/rubygem-mocha/blob/9138921e0c2e7cea4a5b24e6af591f4c1debb513/f/rubygem-mocha.spec#_21 Sorry, I have apparently misplaced my commen. Not sure why I thought I am commenting on rubygem-ruby2_keywords review 🙈 Could you please take a look into enabling the test suite? I understand that there is circular dependency with Faraday, but that should be easy to workaround using bootstrapping: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bootstrapping A think that @jprokop has already provided you with an example here: https://src.fedoraproject.org/rpms/rubygem-cucumber/blob/rawhide/f/rubygem-cucumber.spec#_21 This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. Ok, thanks will work on enabling tests. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. |