Bug 2244463 - Review Request: rubygem-faraday-net_http - Faraday adapter for Net::HTTP
Summary: Review Request: rubygem-faraday-net_http - Faraday adapter for Net::HTTP
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2244212
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-10-16 14:28 UTC by Benson Muite
Modified: 2024-10-22 10:38 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Comment 1 Vít Ondruch 2023-10-16 15:11:27 UTC
I would suggest to close this request. The ruby2_keywords is part of Ruby StdLib:

https://src.fedoraproject.org/rpms/ruby/blob/1f35109c5e7f5df5b51708cc46150b0f4949229a/f/ruby.spec#_1331

Unfortunately, it is not explicitly provided by the `rubygem(ruby2_keywords)` provide. Apart of this being new(ish) feature, it would also be better if this feature was not used, because it basically explicitly says that the specific code uses some deprecated Ruby feature.

BTW probably the best workaround ATM is remove the explicitly generated require:

https://src.fedoraproject.org/rpms/rubygem-mocha/blob/9138921e0c2e7cea4a5b24e6af591f4c1debb513/f/rubygem-mocha.spec#_21

Comment 2 Vít Ondruch 2023-10-16 15:17:22 UTC
Sorry, I have apparently misplaced my commen. Not sure why I thought I am commenting on rubygem-ruby2_keywords review 🙈

Comment 3 Vít Ondruch 2023-10-17 12:36:23 UTC
Could you please take a look into enabling the test suite? I understand that there is circular dependency with Faraday, but that should be easy to workaround using bootstrapping:

https://docs.fedoraproject.org/en-US/packaging-guidelines/#bootstrapping

A think that @jprokop has already provided you with an example here:

https://src.fedoraproject.org/rpms/rubygem-cucumber/blob/rawhide/f/rubygem-cucumber.spec#_21

Comment 4 Package Review 2024-10-17 00:45:23 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 5 Benson Muite 2024-10-22 10:38:55 UTC
Ok, thanks will work on enabling tests.


Note You need to log in before you can comment on or make changes to this bug.