Bug 2244729
Summary: | Review Request: aespipe - AES encrypting or decrypting pipe | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jiri Hladky <hladky.jiri> | ||||||
Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
Status: | POST --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | hladky.jiri, ngompa13, package-review, rjones | ||||||
Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
URL: | http://loop-aes.sourceforge.net/ | ||||||||
Whiteboard: | Unretirement | ||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | Type: | --- | |||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Jiri Hladky
2023-10-17 23:40:20 UTC
Please note that this related to request to unretire rpms/aespipe. Aespipe was included in Fedora upto version 33. https://src.fedoraproject.org/rpms/aespipe# In Fedora-34, build process got broken because of GCC bug. https://koji.fedoraproject.org/koji/packageinfo?packageID=10847 Now the GCC bug was identified and WA was added to the SPEC file. I would like to revive the aespipe package. Copr build: https://copr.fedorainfracloud.org/coprs/build/6540710 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244729-aespipe/fedora-rawhide-x86_64/06540710-aespipe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://jhladky.fedorapeople.org/aespipe.spec SRPM URL: https://jhladky.fedorapeople.org/aespipe-2.4g-1.fc40.src.rpm I have contacted the author and he has updated the sources to automatically add -fno-strict-aliasing compiler flag to WA GCC bug. I have updated tyhe SPEC file to use the latest sources and removed the WA from the spec file. Created attachment 1995245 [details]
The .spec file difference from Copr build 6540710 to 6559462
Copr build: https://copr.fedorainfracloud.org/coprs/build/6559462 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244729-aespipe/fedora-rawhide-x86_64/06559462-aespipe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://jhladky.fedorapeople.org/aespipe.spec SRPM URL: https://jhladky.fedorapeople.org/aespipe-2.4g-1.fc40.src.rpm I have updated the License field in the spec file. Created attachment 1995348 [details]
The .spec file difference from Copr build 6559462 to 6563212
Copr build: https://copr.fedorainfracloud.org/coprs/build/6563212 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244729-aespipe/fedora-rawhide-x86_64/06563212-aespipe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Initial spec review: > Source: http://loop-aes.sourceforge.net/aespipe/aespipe-v%{version}.tar.bz2 This can be simplified to "%{url}/aespipe/aespipe-v%{version}.tar.bz2" > BuildRequires: gcc You also need a "BuildRequires: make" line too. > %setup -q -n %{name}-v%{version} You could use "%autosetup -p1 -n %{name}-v%{version}" instead, which may be useful if you will want patches to auto-apply in the future. > %{_mandir}/man1/* This is too greedy, please use "%{_mandir}/man1/aespipe.1*" instead. Thanks for the review and tips! I have updated the SPEC file accordingly. The package builds fine: https://koji.fedoraproject.org/koji/taskinfo?taskID=108139072 Updated SPEC and SRPMs files: Spec URL: https://jhladky.fedorapeople.org/aespipe.spec SRPM URL: https://jhladky.fedorapeople.org/aespipe-2.4g-1.fc40.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/6567935 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244729-aespipe/fedora-rawhide-x86_64/06567935-aespipe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Hi Neal, could you please review the updated SPEC file? I have incorporated the proposed improvements - see the comments above. Thanks Jirka Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED. Neal, THANK YOU for the review! |