Bug 2244730

Summary: Review Request: kglobalacceld - Daemon providing Global Keyboard Shortcut functionality
Product: [Fedora] Fedora Reporter: Steve Cossette <farchord>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://invent.kde.org/plasma/%{name}
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-18 01:49:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2235556    
Attachments:
Description Flags
The .spec file difference from Copr build 6540715 to 6540747 none

Description Steve Cossette 2023-10-17 23:59:50 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld-5.240.0^20231009.021332.6933aae-1.fc39.src.rpm
Description: Daemon providing Global Keyboard Shortcut functionality.
Fedora Account System Username: farchord
Comment 1 Steve Cossette 2023-10-18 00:01:48 UTC 
Rpmlint
-------
Checking: kglobalacceld-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm
          kglobalacceld-devel-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm
          kglobalacceld-debuginfo-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm
          kglobalacceld-debugsource-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm
          kglobalacceld-5.240.0^20231009.021332.6933aae-1.fc40.src.rpm
==================================================================== rpmlint session starts ===================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpr44az2bm')]
checks: 31, packages: 5

kglobalacceld-devel.x86_64: W: only-non-binary-in-usr-lib
kglobalacceld.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/kglobalacceld.desktop
kglobalacceld.x86_64: W: no-documentation
kglobalacceld-devel.x86_64: W: no-documentation
kglobalacceld.src: W: invalid-license LicenseRef-KDE-Accepted-LGPL
kglobalacceld.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
kglobalacceld-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
kglobalacceld-debugsource.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
kglobalacceld-devel.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
===================================== 5 packages and 0 specfiles checked; 0 errors, 9 warnings, 0 badness; has taken 0.5 s ====================================




Rpmlint (debuginfo)
-------------------
Checking: kglobalacceld-debuginfo-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm
==================================================================== rpmlint session starts ===================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpoml1hlfe')]
checks: 31, packages: 1

kglobalacceld-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
===================================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ====================================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 4

kglobalacceld-devel.x86_64: W: only-non-binary-in-usr-lib
kglobalacceld.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/kglobalacceld.desktop
kglobalacceld.x86_64: W: no-documentation
kglobalacceld-devel.x86_64: W: no-documentation
kglobalacceld-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
kglobalacceld-debugsource.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
kglobalacceld.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
kglobalacceld-devel.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL
 4 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken 0.9 s
Comment 2 Fedora Review Service 2023-10-18 00:14:11 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6540715
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244730-kglobalacceld/fedora-rawhide-x86_64/06540715-kglobalacceld/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 3 Steve Cossette 2023-10-18 00:21:39 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld-5.27.80^20231009.021332.6933aae-1.fc39.src.rpm

Updated version
Comment 4 Fedora Review Service 2023-10-18 00:34:43 UTC 
Created attachment 1994350 [details]
The .spec file difference from Copr build 6540715 to 6540747
Comment 5 Fedora Review Service 2023-10-18 00:34:46 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6540747
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244730-kglobalacceld/fedora-rawhide-x86_64/06540747-kglobalacceld/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 6 Neal Gompa 2023-10-18 01:18:35 UTC 
> /usr/lib/systemd/user/plasma-kglobalaccel.service

"%{_userunitdir}/plasma-kglobalaccel.service"
Comment 7 Steve Cossette 2023-10-18 01:20:57 UTC 
Spec URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld-5.27.80^20231009.021332.6933aae-1.fc39.src.rpm

Updated systemd file macro
Comment 8 Neal Gompa 2023-10-18 01:23:40 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 9 Steve Cossette 2023-10-18 01:47:51 UTC 
Thank you for the review, Neal

https://pagure.io/releng/fedora-scm-requests/issue/57297
Comment 10 Fedora Admin user for bugzilla script actions 2023-10-18 01:48:02 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/kglobalacceld