Spec URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld-5.240.0^20231009.021332.6933aae-1.fc39.src.rpm Description: Daemon providing Global Keyboard Shortcut functionality. Fedora Account System Username: farchord
Rpmlint ------- Checking: kglobalacceld-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm kglobalacceld-devel-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm kglobalacceld-debuginfo-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm kglobalacceld-debugsource-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm kglobalacceld-5.240.0^20231009.021332.6933aae-1.fc40.src.rpm ==================================================================== rpmlint session starts =================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpr44az2bm')] checks: 31, packages: 5 kglobalacceld-devel.x86_64: W: only-non-binary-in-usr-lib kglobalacceld.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/kglobalacceld.desktop kglobalacceld.x86_64: W: no-documentation kglobalacceld-devel.x86_64: W: no-documentation kglobalacceld.src: W: invalid-license LicenseRef-KDE-Accepted-LGPL kglobalacceld.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kglobalacceld-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kglobalacceld-debugsource.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kglobalacceld-devel.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL ===================================== 5 packages and 0 specfiles checked; 0 errors, 9 warnings, 0 badness; has taken 0.5 s ==================================== Rpmlint (debuginfo) ------------------- Checking: kglobalacceld-debuginfo-5.240.0^20231009.021332.6933aae-1.fc40.x86_64.rpm ==================================================================== rpmlint session starts =================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpoml1hlfe')] checks: 31, packages: 1 kglobalacceld-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL ===================================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ==================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 4 kglobalacceld-devel.x86_64: W: only-non-binary-in-usr-lib kglobalacceld.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/kglobalacceld.desktop kglobalacceld.x86_64: W: no-documentation kglobalacceld-devel.x86_64: W: no-documentation kglobalacceld-debuginfo.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kglobalacceld-debugsource.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kglobalacceld.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL kglobalacceld-devel.x86_64: W: invalid-license LicenseRef-KDE-Accepted-LGPL 4 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken 0.9 s
Copr build: https://copr.fedorainfracloud.org/coprs/build/6540715 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244730-kglobalacceld/fedora-rawhide-x86_64/06540715-kglobalacceld/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld-5.27.80^20231009.021332.6933aae-1.fc39.src.rpm Updated version
Created attachment 1994350 [details] The .spec file difference from Copr build 6540715 to 6540747
Copr build: https://copr.fedorainfracloud.org/coprs/build/6540747 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244730-kglobalacceld/fedora-rawhide-x86_64/06540747-kglobalacceld/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> /usr/lib/systemd/user/plasma-kglobalaccel.service "%{_userunitdir}/plasma-kglobalaccel.service"
Spec URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld.spec SRPM URL: https://farchord.fedorapeople.org/reviews/kglobalacceld/kglobalacceld-5.27.80^20231009.021332.6933aae-1.fc39.src.rpm Updated systemd file macro
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
Thank you for the review, Neal https://pagure.io/releng/fedora-scm-requests/issue/57297
The Pagure repository was created at https://src.fedoraproject.org/rpms/kglobalacceld