Bug 2244820
| Summary: | Review Request: xevd - Reference MPEG-5 Part 1 (EVC) decoder | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Neal Gompa <ngompa13> | ||||
| Component: | Package Review | Assignee: | Simone Caronni <negativo17> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | negativo17, package-review | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | Flags: | negativo17:
fedora-review+
|
||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/mpeg5/xevd | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | xevd-0.5.0-2.fc43 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2025-05-11 17:01:45 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2218117 | ||||||
| Attachments: |
|
||||||
|
Description
Neal Gompa
2023-10-18 12:46:03 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6543577 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244820-xevd/fedora-rawhide-x86_64/06543577-xevd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Requesting FE-Legal to review whether the stripping is sufficient. The line "Requires: %{name}%{?_isa} = %{version}-%{release}" at the top can be removed. It requires itself, and if the original intention was requiring the libraries, those are satisfied anyway by the automatic dependencies.
@ngompa13 There's version 0.5.1 which contains your patches. Update to latest version (0.5.0): Spec URL: https://ngompa.fedorapeople.org/for-review/xevd.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/xevd-0.5.0-1.fc39.src.rpm Oops, wrong SRPM URL... Update to latest version (0.5.0): Spec URL: https://ngompa.fedorapeople.org/for-review/xevd.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/xevd-0.5.0-1.fc40.src.rpm There seems to be some problem with the following file. SRPM URL: https://ngompa.fedorapeople.org/for-review/xevd-0.5.0-1.fc39.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2049473 [details]
The .spec file difference from Copr build 6543577 to 8091459
Copr build: https://copr.fedorainfracloud.org/coprs/build/8091459 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2244820-xevd/fedora-rawhide-x86_64/08091459-xevd/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Any update from FE-Legal?... it's almost 3 months now. Per discussion with mattdm, lifting FE-Legal. @ngompa13 what does it mean removing fedora-review? FE-Legal has blocked importing? There are a few commits in master after 0.5.0, it seems the package can be compiled as well on ARM; it might be worth investigating. (In reply to Simone Caronni from comment #12) > @ngompa13 what does it mean removing fedora-review? FE-Legal has > blocked importing? > The fedora-review tag was associated with ppisar, not you, so I removed it. You need to set it yourself. > There are a few commits in master after 0.5.0, it seems the package can be > compiled as well on ARM; it might be worth investigating. I'll look into it later. Package approved. Please fix the changelog before importing (or switch to autospec): xevd.x86_64: W: incoherent-version-in-changelog 0.4.1-1 ['0.5.0-1.fc42', '0.5.0-1'] Thanks. The Pagure repository was created at https://src.fedoraproject.org/rpms/xevd |