Bug 2245301

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=107833062

> # Tests available only on Github
> %if %{with check}
> Source:         https://github.com/marirs/%{crate}/archive/%{nparse_commit}/%{crate}-%{nparse_shortcommit}.tar.gz
> %else
> Source:         %{crates_source}
> %endif

Sources should not be conditionalized like this.
Also, Rust crates MUST use the sources from crates.io (i.e. %{crates_source}).

If a published crate tarball doesn't ship sources for tests, just don't run those tests.
You can control which kinds of tests are run by passing flags like "-- --lib", "-- --doc", or "-- --tests" to "%cargo_test".

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6552058
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245301-rust-nparse/fedora-rawhide-x86_64/06552058-rust-nparse/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-39-x86_64/06553873-rust-nparse/rust-nparse.spec
https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-39-x86_64/06553873-rust-nparse/rust-nparse-0.0.10-1.fc39.src.rpm

Looks good to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (disabled with explanation)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)


===

> # https://github.com/marirs/nparse/issues/5

This can probably be removed? The license metadata is present in the packaged version.

(In reply to Fabio Valentini from comment #5)
> > # https://github.com/marirs/nparse/issues/5
> 
> This can probably be removed? The license metadata is present in the
> packaged version.

I'll remove this leftovers before import.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nparse

FEDORA-2023-4d3be8fb94 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4d3be8fb94

FEDORA-2023-4d3be8fb94 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2023-09bb6a7531 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-09bb6a7531

FEDORA-2023-09bb6a7531 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-09bb6a7531`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-09bb6a7531

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2023-09bb6a7531 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.