Bug 2245301 - Review Request: rust-nparse - Parser in rust for specific use-cases
Summary: Review Request: rust-nparse - Parser in rust for specific use-cases
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/nparse
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-10-20 16:57 UTC by Artem
Modified: 2023-11-03 18:44 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-22 13:07:11 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Artem 2023-10-20 16:57:59 UTC
Spec URL: https://atim.fedorapeople.org/rust-nparse.spec
SRPM URL: https://atim.fedorapeople.org/rust-nparse-0.0.9-1.fc39.src.rpm

Description:
Parser in rust for specific use-cases.

Fedora Account System Username: atim

Comment 1 Artem 2023-10-20 16:58:02 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=107833062

Comment 2 Fabio Valentini 2023-10-20 17:12:18 UTC
> # Tests available only on Github
> %if %{with check}
> Source:         https://github.com/marirs/%{crate}/archive/%{nparse_commit}/%{crate}-%{nparse_shortcommit}.tar.gz
> %else
> Source:         %{crates_source}
> %endif

Sources should not be conditionalized like this.
Also, Rust crates MUST use the sources from crates.io (i.e. %{crates_source}).

If a published crate tarball doesn't ship sources for tests, just don't run those tests.
You can control which kinds of tests are run by passing flags like "-- --lib", "-- --doc", or "-- --tests" to "%cargo_test".

Comment 3 Fedora Review Service 2023-10-20 21:05:07 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6552058
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2245301-rust-nparse/fedora-rawhide-x86_64/06552058-rust-nparse/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2023-10-22 10:06:58 UTC
Looks good to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (disabled with explanation)
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)


===

> # https://github.com/marirs/nparse/issues/5

This can probably be removed? The license metadata is present in the packaged version.

Comment 6 Artem 2023-10-22 12:46:22 UTC
(In reply to Fabio Valentini from comment #5)
> > # https://github.com/marirs/nparse/issues/5
> 
> This can probably be removed? The license metadata is present in the
> packaged version.

I'll remove this leftovers before import.

Comment 7 Fedora Admin user for bugzilla script actions 2023-10-22 12:47:45 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nparse

Comment 8 Fedora Update System 2023-10-22 13:04:56 UTC
FEDORA-2023-4d3be8fb94 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-4d3be8fb94

Comment 9 Fedora Update System 2023-10-22 13:07:11 UTC
FEDORA-2023-4d3be8fb94 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2023-10-22 14:29:25 UTC
FEDORA-2023-09bb6a7531 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-09bb6a7531

Comment 11 Fedora Update System 2023-10-23 01:38:28 UTC
FEDORA-2023-09bb6a7531 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-09bb6a7531`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-09bb6a7531

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2023-11-03 18:44:01 UTC
FEDORA-2023-09bb6a7531 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.