Bug 2245791

Summary: libcec fails to build with Python 3.13: error: implicit declaration of function ‘PyEval_InitThreads’, 'PyEval_CallObject'
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: libcecAssignee: Andrew Bauer <zonexpertconsulting>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ksurma, mhroncok, pikachu.2014, zonexpertconsulting
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-10-25 17:55:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2244836    

Description Karolina Surma 2023-10-24 07:43:31 UTC
libcec fails to build with Python 3.13.0a1.

/builddir/build/BUILD/libcec-libcec-6.0.2/redhat-linux-build/src/libcec/CMakeFiles/_cec.dir/libcecPYTHON_wrap.cxx:5497:9: error: ‘PyEval_InitThreads’ was not declared in this scope; did you mean ‘PyEval_SaveThread’?
 5497 |         PyEval_InitThreads();
      |         ^~~~~~~~~~~~~~~~~~
      |         PyEval_SaveThread


/builddir/build/BUILD/libcec-libcec-6.0.2/src/libcec/SwigHelper.h:122:18: error: ‘PyEval_CallObject’ was not declared in this scope; did you mean ‘PyObject_CallObject’?
  122 |         result = PyEval_CallObject(m_callbacks[callback], arglist);
      |                  ^~~~~~~~~~~~~~~~~
      |                  PyObject_CallObject


According to https://docs.python.org/3.13/whatsnew/3.13.html:

- Remove PyEval_InitThreads() and PyEval_ThreadsInitialized() functions, deprecated in Python 3.9. Since Python 3.7, Py_Initialize() always creates the GIL:
calling PyEval_InitThreads() did nothing and PyEval_ThreadsInitialized() always returned non-zero.
(Contributed by Victor Stinner in https://github.com/python/cpython/issues/105182.)

- Remove PyEval_CallObject(), PyEval_CallObjectWithKeywords(): use PyObject_CallNoArgs() or PyObject_Call() instead. Warning: PyObject_Call() positional arguments must be a tuple and must not be NULL, keyword arguments must be a dict or NULL, whereas removed functions checked arguments type and accepted NULL positional and keyword arguments. To replace PyEval_CallObjectWithKeywords(func, NULL, kwargs) with PyObject_Call(), pass an empty tuple as positional arguments using PyTuple_New(0).

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546798-libcec/

For all our attempts to build libcec with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/libcec/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.