Bug 2245791 - libcec fails to build with Python 3.13: error: implicit declaration of function ‘PyEval_InitThreads’, 'PyEval_CallObject'
Summary: libcec fails to build with Python 3.13: error: implicit declaration of functi...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: libcec
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Andrew Bauer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.13
TreeView+ depends on / blocked
 
Reported: 2023-10-24 07:43 UTC by Karolina Surma
Modified: 2023-10-25 17:55 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-25 17:55:01 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2023-10-24 07:43:31 UTC
libcec fails to build with Python 3.13.0a1.

/builddir/build/BUILD/libcec-libcec-6.0.2/redhat-linux-build/src/libcec/CMakeFiles/_cec.dir/libcecPYTHON_wrap.cxx:5497:9: error: ‘PyEval_InitThreads’ was not declared in this scope; did you mean ‘PyEval_SaveThread’?
 5497 |         PyEval_InitThreads();
      |         ^~~~~~~~~~~~~~~~~~
      |         PyEval_SaveThread


/builddir/build/BUILD/libcec-libcec-6.0.2/src/libcec/SwigHelper.h:122:18: error: ‘PyEval_CallObject’ was not declared in this scope; did you mean ‘PyObject_CallObject’?
  122 |         result = PyEval_CallObject(m_callbacks[callback], arglist);
      |                  ^~~~~~~~~~~~~~~~~
      |                  PyObject_CallObject


According to https://docs.python.org/3.13/whatsnew/3.13.html:

- Remove PyEval_InitThreads() and PyEval_ThreadsInitialized() functions, deprecated in Python 3.9. Since Python 3.7, Py_Initialize() always creates the GIL:
calling PyEval_InitThreads() did nothing and PyEval_ThreadsInitialized() always returned non-zero.
(Contributed by Victor Stinner in https://github.com/python/cpython/issues/105182.)

- Remove PyEval_CallObject(), PyEval_CallObjectWithKeywords(): use PyObject_CallNoArgs() or PyObject_Call() instead. Warning: PyObject_Call() positional arguments must be a tuple and must not be NULL, keyword arguments must be a dict or NULL, whereas removed functions checked arguments type and accepted NULL positional and keyword arguments. To replace PyEval_CallObjectWithKeywords(func, NULL, kwargs) with PyObject_Call(), pass an empty tuple as positional arguments using PyTuple_New(0).

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06546798-libcec/

For all our attempts to build libcec with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/libcec/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.


Note You need to log in before you can comment on or make changes to this bug.