Bug 2246013

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6563207
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246013-rust-trycmd/fedora-rawhide-x86_64/06563207-rust-trycmd/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Taking this review

General comments:

- Package was generated with rust2rpm

Issues:

- Binary package has an invalid license tag
  Seeing that the "FIXME" comment is still in the spec, I assume you only want to package the library crate and simply forgot to remove the binary package

Package looks good except the mentioned issue. Once that is fixed, I can approve this package.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. No licenses
     found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10171 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in trycmd ,
     rust-trycmd-devel , rust-trycmd+default-devel , rust-trycmd+color-
     devel , rust-trycmd+color-auto-devel , rust-trycmd+debug-devel , rust-
     trycmd+diff-devel , rust-trycmd+escargot-devel , rust-trycmd+examples-
     devel , rust-trycmd+filesystem-devel , rust-trycmd+schema-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: No rpmlint messages.
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Rpmlint
-------
Checking: trycmd-0.14.19-1.fc40.x86_64.rpm
          rust-trycmd-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+default-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+color-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+color-auto-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+debug-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+diff-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+escargot-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+examples-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+filesystem-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd+schema-devel-0.14.19-1.fc40.noarch.rpm
          rust-trycmd-debugsource-0.14.19-1.fc40.x86_64.rpm
          rust-trycmd-0.14.19-1.fc40.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpkqyz6mim')]
checks: 31, packages: 13

trycmd.x86_64: W: no-manual-page-for-binary bin-fixture
trycmd.x86_64: W: no-manual-page-for-binary trycmd-schema
rust-trycmd+color-auto-devel.noarch: W: no-documentation
rust-trycmd+color-devel.noarch: W: no-documentation
rust-trycmd+debug-devel.noarch: W: no-documentation
rust-trycmd+default-devel.noarch: W: no-documentation
rust-trycmd+diff-devel.noarch: W: no-documentation
rust-trycmd+escargot-devel.noarch: W: no-documentation
rust-trycmd+examples-devel.noarch: W: no-documentation
rust-trycmd+filesystem-devel.noarch: W: no-documentation
rust-trycmd+schema-devel.noarch: W: no-documentation
trycmd.x86_64: W: invalid-license # FIXME
rust-trycmd-devel.noarch: W: files-duplicate /usr/share/cargo/registry/trycmd-0.14.19/src/bin/bin-fixture.rs /usr/share/cargo/registry/trycmd-0.14.19/examples/example-fixture.rs
 13 packages and 0 specfiles checked; 0 errors, 13 warnings, 0 badness; has taken 0.4 s




Rpmlint (installed packages)
----------------------------
(none): E: there is no installed rpm "rust-trycmd+debug-devel".
(none): E: there is no installed rpm "trycmd".
(none): E: there is no installed rpm "rust-trycmd+examples-devel".
(none): E: there is no installed rpm "rust-trycmd+color-auto-devel".
(none): E: there is no installed rpm "rust-trycmd+default-devel".
(none): E: there is no installed rpm "rust-trycmd-debugsource".
(none): E: there is no installed rpm "rust-trycmd+color-devel".
(none): E: there is no installed rpm "rust-trycmd+escargot-devel".
(none): E: there is no installed rpm "rust-trycmd-devel".
(none): E: there is no installed rpm "rust-trycmd+filesystem-devel".
(none): E: there is no installed rpm "rust-trycmd+schema-devel".
(none): E: there is no installed rpm "rust-trycmd+diff-devel".
There are no files to process nor additional arguments.
Nothing to do, aborting.
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 12

 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s



Source checksums
----------------
https://crates.io/api/v1/crates/trycmd/0.14.19/download#/trycmd-0.14.19.crate :
  CHECKSUM(SHA256) this package     : ed009372a42fb103e6f8767b9222925485e03cca032b700d203e2c5b67bee4fb
  CHECKSUM(SHA256) upstream package : ed009372a42fb103e6f8767b9222925485e03cca032b700d203e2c5b67bee4fb


Requires
--------
trycmd (rpmlib, GLIBC filtered):
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3)(64bit)
    libgcc_s.so.1(GCC_4.2.0)(64bit)
    libm.so.6()(64bit)
    rtld(GNU_HASH)

rust-trycmd-devel (rpmlib, GLIBC filtered):
    (crate(glob/default) >= 0.3.0 with crate(glob/default) < 0.4.0~)
    (crate(humantime-serde/default) >= 1.0.0 with crate(humantime-serde/default) < 2.0.0~)
    (crate(humantime/default) >= 2.0.0 with crate(humantime/default) < 3.0.0~)
    (crate(rayon/default) >= 1.5.1 with crate(rayon/default) < 2.0.0~)
    (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0~)
    (crate(serde/derive) >= 1.0.0 with crate(serde/derive) < 2.0.0~)
    (crate(shlex/default) >= 1.1.0 with crate(shlex/default) < 2.0.0~)
    (crate(snapbox) >= 0.4.14 with crate(snapbox) < 0.5.0~)
    (crate(snapbox/cmd) >= 0.4.14 with crate(snapbox/cmd) < 0.5.0~)
    (crate(toml_edit/default) >= 0.20.0 with crate(toml_edit/default) < 0.21.0~)
    (crate(toml_edit/serde) >= 0.20.0 with crate(toml_edit/serde) < 0.21.0~)
    cargo
    rust

rust-trycmd+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(trycmd)
    crate(trycmd/color-auto)
    crate(trycmd/diff)
    crate(trycmd/filesystem)

rust-trycmd+color-devel (rpmlib, GLIBC filtered):
    (crate(anstream/default) >= 0.6.0 with crate(anstream/default) < 0.7.0~)
    (crate(snapbox/color) >= 0.4.14 with crate(snapbox/color) < 0.5.0~)
    cargo
    crate(trycmd)

rust-trycmd+color-auto-devel (rpmlib, GLIBC filtered):
    (crate(snapbox/color-auto) >= 0.4.14 with crate(snapbox/color-auto) < 0.5.0~)
    cargo
    crate(trycmd)

rust-trycmd+debug-devel (rpmlib, GLIBC filtered):
    (crate(snapbox/debug) >= 0.4.14 with crate(snapbox/debug) < 0.5.0~)
    cargo
    crate(trycmd)

rust-trycmd+diff-devel (rpmlib, GLIBC filtered):
    (crate(snapbox/diff) >= 0.4.14 with crate(snapbox/diff) < 0.5.0~)
    cargo
    crate(trycmd)

rust-trycmd+escargot-devel (rpmlib, GLIBC filtered):
    (crate(escargot/default) >= 0.5.7 with crate(escargot/default) < 0.6.0~)
    cargo
    crate(trycmd)

rust-trycmd+examples-devel (rpmlib, GLIBC filtered):
    (crate(snapbox/examples) >= 0.4.14 with crate(snapbox/examples) < 0.5.0~)
    cargo
    crate(trycmd)

rust-trycmd+filesystem-devel (rpmlib, GLIBC filtered):
    (crate(snapbox/path) >= 0.4.14 with crate(snapbox/path) < 0.5.0~)
    cargo
    crate(trycmd)

rust-trycmd+schema-devel (rpmlib, GLIBC filtered):
    (crate(schemars/default) >= 0.8.3 with crate(schemars/default) < 0.9.0~)
    (crate(schemars/preserve_order) >= 0.8.3 with crate(schemars/preserve_order) < 0.9.0~)
    (crate(serde_json/default) >= 1.0.0 with crate(serde_json/default) < 2.0.0~)
    cargo
    crate(trycmd)

rust-trycmd-debugsource (rpmlib, GLIBC filtered):



Provides
--------
trycmd:
    trycmd
    trycmd(x86-64)

rust-trycmd-devel:
    crate(trycmd)
    rust-trycmd-devel

rust-trycmd+default-devel:
    crate(trycmd/default)
    rust-trycmd+default-devel

rust-trycmd+color-devel:
    crate(trycmd/color)
    rust-trycmd+color-devel

rust-trycmd+color-auto-devel:
    crate(trycmd/color-auto)
    rust-trycmd+color-auto-devel

rust-trycmd+debug-devel:
    crate(trycmd/debug)
    rust-trycmd+debug-devel

rust-trycmd+diff-devel:
    crate(trycmd/diff)
    rust-trycmd+diff-devel

rust-trycmd+escargot-devel:
    crate(trycmd/escargot)
    rust-trycmd+escargot-devel

rust-trycmd+examples-devel:
    crate(trycmd/examples)
    rust-trycmd+examples-devel

rust-trycmd+filesystem-devel:
    crate(trycmd/filesystem)
    rust-trycmd+filesystem-devel

rust-trycmd+schema-devel:
    crate(trycmd/schema)
    rust-trycmd+schema-devel

rust-trycmd-debugsource:
    rust-trycmd-debugsource
    rust-trycmd-debugsource(x86-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-trycmd --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: SugarActivity, fonts, PHP, Python, Ocaml, R, C/C++, Java, Haskell, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

You're right, I seem to have uploaded this package before it was ready. Sorry about that!
I've removed the binaries from the package. Updated files are behind the same URLs.

Looks good now!

APPROVED

Thank you!

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trycmd

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-69d9db3f45