Bug 2246014 - Review Request: rust-schemars - Generate JSON Schemas from Rust code
Summary: Review Request: rust-schemars - Generate JSON Schemas from Rust code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: fedora.dm0
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/schemars
Whiteboard:
Depends On: 2246011 2246012
Blocks: 2246013
TreeView+ depends on / blocked
 
Reported: 2023-10-24 23:54 UTC by Fabio Valentini
Modified: 2023-11-23 00:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-23 00:09:42 UTC
Type: ---
Embargoed:
fedora.dm0: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-10-24 23:54:12 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-schemars.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-schemars-0.8.15-1.fc39.src.rpm

Description:
Generate JSON Schemas from Rust code.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-10-25 02:28:07 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6563208
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246014-rust-schemars/fedora-rawhide-x86_64/06563208-rust-schemars/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 fedora.dm0 2023-11-22 15:11:03 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is NOT packaged (see note)
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

A new version was released only to stay in sync with schemars_derive.  Upgrading just consists of bumping the version number, and everything still seems to work as before.

Comment 3 Fabio Valentini 2023-11-22 23:04:21 UTC
Thanks for the review! I'll update to the latest version ASAP.

Comment 4 Fedora Admin user for bugzilla script actions 2023-11-22 23:09:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-schemars

Comment 5 Fedora Update System 2023-11-23 00:08:06 UTC
FEDORA-2023-0c864830f5 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0c864830f5

Comment 6 Fedora Update System 2023-11-23 00:09:42 UTC
FEDORA-2023-0c864830f5 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.