Bug 2246767
| Summary: | Review Request: qvr - QT library for VR applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-10-31 15:58:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2244984, 2246766 | ||
| Bug Blocks: | 2246848 | ||
|
Description
Davide Cavalca
2023-10-28 17:36:08 UTC
I wanted to build the included examples as well but I can't figure out a way to get cmake to detect the just-built libqvr and use that, instead of looking for it in the standard locations (as otherwise I'd need to use the bootstrap approach and build twice, which seems way overkill for this). Copr build: https://copr.fedorainfracloud.org/coprs/build/6577380 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246767-qvr/srpm-builds/06577380/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://dcavalca.fedorapeople.org/review/qvr/qvr.spec SRPM URL: https://dcavalca.fedorapeople.org/review/qvr/qvr-4.0.1-1.fc40.src.rpm Changelog: - add Requires to -devel subpackage Review notes:
* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint
There is a minor spec fixup you should do when importing though: "%{_libdir}/lib%{name}.so.4*" is too greedy. Use "%{_libdir}/lib%{name}.so.4{,.*}" instead.
PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/qvr FEDORA-2023-478c85166f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-478c85166f FEDORA-2023-478c85166f has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2023-10af6b1e28 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-10af6b1e28 FEDORA-2023-10af6b1e28 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-10af6b1e28 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-10af6b1e28 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2023-10af6b1e28 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. |