Bug 2246767 - Review Request: qvr - QT library for VR applications
Summary: Review Request: qvr - QT library for VR applications
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2244984 2246766
Blocks: 2246848
TreeView+ depends on / blocked
 
Reported: 2023-10-28 17:36 UTC by Davide Cavalca
Modified: 2023-11-03 18:48 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-10-31 15:58:12 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2023-10-28 17:36:08 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/qvr/qvr.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/qvr/qvr-4.0.1-1.fc40.src.rpm

Description:
QVR is a library that makes writing Virtual Reality (VR) applications very
easy. It is based on Qt and requires no other libraries.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-10-28 17:37:33 UTC
I wanted to build the included examples as well but I can't figure out a way to get cmake to detect the just-built libqvr and use that, instead of looking for it in the standard locations (as otherwise I'd need to use the bootstrap approach and build twice, which seems way overkill for this).

Comment 2 Fedora Review Service 2023-10-29 01:35:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6577380
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246767-qvr/srpm-builds/06577380/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2023-10-29 15:59:16 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/qvr/qvr.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/qvr/qvr-4.0.1-1.fc40.src.rpm

Changelog:
- add Requires to -devel subpackage

Comment 4 Neal Gompa 2023-10-29 18:34:31 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

There is a minor spec fixup you should do when importing though: "%{_libdir}/lib%{name}.so.4*" is too greedy. Use "%{_libdir}/lib%{name}.so.4{,.*}" instead.

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-10-31 15:41:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/qvr

Comment 6 Fedora Update System 2023-10-31 15:56:00 UTC
FEDORA-2023-478c85166f has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-478c85166f

Comment 7 Fedora Update System 2023-10-31 15:58:12 UTC
FEDORA-2023-478c85166f has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-10-31 18:10:05 UTC
FEDORA-2023-10af6b1e28 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-10af6b1e28

Comment 9 Fedora Update System 2023-11-01 01:29:03 UTC
FEDORA-2023-10af6b1e28 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-10af6b1e28 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-10af6b1e28

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2023-11-03 18:48:09 UTC
FEDORA-2023-10af6b1e28 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.