Bug 2246779
| Summary: | Review Request: rust-finl_unicode - Library for handling Unicode functionality for finl | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Davide Cavalca <davide> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | davide, decathorpe, leo, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-01-04 00:46:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 2169188 | ||
|
Description
Michel Lind
2023-10-28 21:23:42 UTC
Note: re-review of #2138983 Addresses the issues there - Criterion dependency dropped, and for completeness, resources for benchmark deleted as they are under different licenses - PR filed to include the Unicode license text, and the license and text pulled in the spec https://github.com/dahosek/finl_unicode/pull/17 Copr build: https://copr.fedorainfracloud.org/coprs/build/6577378 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246779-rust-finl_unicode/srpm-builds/06577378/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED (with requests for changes). Hold on - you will also need to fix the license in crate metadata with a Cargo.toml patch. Otherwise %cargo_license macro will not work correctly, since it operates on crate metadata, not RPM license tags. Note: Another package package for this crate has been submitted for review (#2250496), and I only noticed that there's already an existing review after I took another look at the package. At the very least, the crate has contents that cannot be shipped in this form as a Fedora package (mostly text content that is used for benchmarking, but only available under various, not necessarily "allowed", licenses). *** Bug 2250496 has been marked as a duplicate of this bug. *** This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. Sigh, wezterm will never get into Fedora it seems. Ah well, we should probably see if upstream can drop this problematic dependency |