Bug 2250496 - Review Request: rust-finl_unicode - Library for handling Unicode functionality for finl
Summary: Review Request: rust-finl_unicode - Library for handling Unicode functionalit...
Keywords:
Status: CLOSED DUPLICATE of bug 2246779
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-11-19 04:08 UTC by Leo Puvilland
Modified: 2023-11-25 19:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-25 19:00:06 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Leo Puvilland 2023-11-19 04:08:20 UTC
Spec URL: https://pagure.io/leo/rpms-wip/raw/master/f/rust-finl_unicode/rust-finl_unicode.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/leo/rpms-wip/srpm-builds/06667390/rust-finl_unicode-1.2.0-1.src.rpm
Description: Library for handling Unicode functionality for finl (categories and grapheme segmentation).
Fedora Account System Username: leo

Scratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=109237762

Comment 1 Fabio Valentini 2023-11-25 18:55:52 UTC
There's a couple things in this crate that are potentially problematic, and likely can't be shipped in this form (from "worst" problem to "least bad"):

- The code in src/data/*.rs appears to have been generated from Unicode data.

In most circumstances, that means the generated code is licensed under the terms of the Unicode-DFS-2016 license.
The code only has a generic "this is generated, do not edit" header, but doesn't state *what* the code was generated *from*.

If it is indeed the case that it was generated from Unicode data, the crate's license metadata in Cargo.toml metadata must be amended to "(MIT OR Apache-2.0) AND Unicode-DFS-2016" (similar to what the https://crates.io/crates/unicode-ident crate does). Additionally, the crate would need to carry the actual Unicode license text (see also the GitHub project for the unicode-ident crate).

You will likely need to ask the upstream project for clarification on these points.

- The resources in "resources/benchmark-texts" are covered under a variety of licenses (Project Gutenberg, CC-BY-SA 3.0, Apache-2.0, Unicode, ...), not all of which are always permissible for package contents.

I think at the very least, the texts from Project Gutenberg need to be expunged from the package entirely (i.e. a "cleaned" source tarball needs to be created without these files), since it is likely that Fedora is not allowed to distributed these files. It appears that these files are only read by benchmarks, so the "resources" directory should be removable without affecting the functionality of the crate.

Comment 2 Fabio Valentini 2023-11-25 18:57:44 UTC
Additionally, this package has already been submitted for review here: #2246779 (where apparently the problematic contents were missed).

Comment 3 Fabio Valentini 2023-11-25 19:00:06 UTC

*** This bug has been marked as a duplicate of bug 2246779 ***


Note You need to log in before you can comment on or make changes to this bug.