Bug 2246844

Summary: Review Request: polonium - Tiling window manager for KWin
Product: [Fedora] Fedora Reporter: Robert-André Mauchin 🐧 <eclipseo>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review?
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Robert-André Mauchin 🐧 2023-10-29 15:08:48 UTC
Spec URL: https://eclipseo.fedorapeople.org/for-review/polonium.spec
SRPM URL: https://eclipseo.fedorapeople.org/for-review/polonium-1.0-0.1.20231029git2e4c5bd.fc39.src.rpm

Description:
An (unofficial) successor to Bismuth built on KWin 5.27.  Features:  - Actual tiling backend using binary trees and decent enough code where you    can mod in your own  - Edit tile sizes with the integrated KWin GUI  - Move and tile windows with your mouse and keyboard  - Set layouts independently of desktop  X11 has been briefly tested but is not officially supported. If you encounter an issue running the script on X11, make sure it is reproducible in Wayland before submitting a bug report.

Fedora Account System Username: eclipseo

Comment 3 Neal Gompa 2023-10-29 17:55:46 UTC
Taking this review.

Comment 4 Neal Gompa 2023-10-29 17:59:05 UTC
Why is the version-release "0.6.0-1.20231029git94ba0fa.fc39"? If it's a snapshot version, it should use standard versioning instead of the legacy one.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_handling_non_sorting_versions_with_tilde_dot_and_caret

Comment 5 Fedora Review Service 2023-10-30 15:15:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6581578
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246844-polonium/srpm-builds/06581578/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fedora Review Service 2023-10-30 15:15:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6581579
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246844-polonium/srpm-builds/06581579/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fedora Review Service 2023-10-30 15:20:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6581888
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2246844-polonium/fedora-rawhide-x86_64/06581888-polonium/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Robert-André Mauchin 🐧 2023-10-30 17:13:30 UTC
> Why is the version-release "0.6.0-1.20231029git94ba0fa.fc39"? If it's a snapshot version, it should use standard versioning instead of the legacy one.

This 
https://pagure.io/packaging-committee/pull-request/1073#request_diff

Was never announced on devel or devel-announce according to search in my mailbox. 
How are we supposed to know if it is not announced, I don't check every common pages for changes. I don't even think forge macros are updated to reflect this.

Comment 9 Package Review 2024-10-30 00:45:25 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 10 Neal Gompa 2024-10-30 15:03:35 UTC
This needs to be refreshed for KDE Plasma 6.