Bug 2247957

Summary:	Review Request: rust-effective-limits - Estimate effective resource limits for a process
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Seth Maurice-Brant <fedoraproject.kwudj>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	fedoraproject.kwudj, package-review
Target Milestone:	---	Flags:	fedoraproject.kwudj: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rust-effective-limits-0.5.5-1.fc40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-07 18:08:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Valentini 2023-11-05 00:54:20 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-effective-limits.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-effective-limits-0.5.5-1.fc39.src.rpm

Description:
Estimate effective resource limits for a process e.g. how much RAM is
available for use.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-11-05 00:54:22 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=108593569

Comment 2 Fedora Review Service 2023-11-05 03:16:06 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6599198
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2247957-rust-effective-limits/srpm-builds/06599198/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Seth Maurice-Brant 2023-11-07 17:27:22 UTC

- Naming and other basics looks OK
- Spec file is legible
- Sources match upstream]
- Koji build provided did pass and is for this package
- Built with rust2rpm, greatly simplifying checks and reducing chance of issues
- Builds and installs correctly from fedora-review
- License is included (LICENSE-APACHE)

===

After running a variety of tests and checks, I have decided that this package meets all the MUST requirements (https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_things_to_check_on_review) and I can ACCEPT this package.

Comment 4 Fabio Valentini 2023-11-07 17:44:55 UTC

Thanks for the review!

As for the diff between spec and SRPM file, it looks like I didn't rebuild the SRPM after adding the link to my upstream PR to the spec file. I will make sure to import the correct version.

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-07 17:46:01 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-effective-limits

Comment 6 Fabio Valentini 2023-11-07 18:08:41 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-01eb7f6a00