Spec URL: https://decathorpe.fedorapeople.org/rust-effective-limits.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-effective-limits-0.5.5-1.fc39.src.rpm Description: Estimate effective resource limits for a process e.g. how much RAM is available for use. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=108593569
Copr build: https://copr.fedorainfracloud.org/coprs/build/6599198 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2247957-rust-effective-limits/srpm-builds/06599198/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
- Naming and other basics looks OK - Spec file is legible - Sources match upstream] - Koji build provided did pass and is for this package - Built with rust2rpm, greatly simplifying checks and reducing chance of issues - Builds and installs correctly from fedora-review - License is included (LICENSE-APACHE) === After running a variety of tests and checks, I have decided that this package meets all the MUST requirements (https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/#_things_to_check_on_review) and I can ACCEPT this package.
Thanks for the review! As for the diff between spec and SRPM file, it looks like I didn't rebuild the SRPM after adding the link to my upstream PR to the spec file. I will make sure to import the correct version.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-effective-limits
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-01eb7f6a00