Bug 2248926
| Summary: | Review Request: rust-jxl-oxide - JPEG XL decoder written in pure Rust | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <klember> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://crates.io/crates/jxl-oxide | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2023-11-15 01:48:35 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2248916, 2248918, 2248920, 2248921, 2248924, 2248925 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Kalev Lember
2023-11-09 17:22:50 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6616692 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248926-rust-jxl-oxide/fedora-rawhide-x86_64/06616692-rust-jxl-oxide/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Two requests for changes: - Drop the "generate-fixtures" binary. It appears to be used in the project's test suite, but the tests themselves are not shipped with this crate. Adding `autobins = false` under the [package] table should do it. This will make this a library-only crate, making the packaging simpler as well. - Turn off the check %bcond. All dev-dependencies are unused, since the test sources themselves are not shipped with the crate. Thanks a lot for the review (and for the rest of the jxl stack!), Fabio! I think your suggestions make a lot of sense -- I've updated the spec file. * Tue Nov 14 2023 Kalev Lember <klember> - 0.3.0-3 - Disable check as all tests are excluded in the crate (rhbz#2248926) * Tue Nov 14 2023 Kalev Lember <klember> - 0.3.0-2 - Drop unwanted "generate-fixtures" binary (rhbz#2248926) Spec URL: https://kalev.fedorapeople.org/rust-jxl-oxide.spec SRPM URL: https://kalev.fedorapeople.org/rust-jxl-oxide-0.3.0-3.fc40.src.rpm Created attachment 1999459 [details]
The .spec file difference from Copr build 6616692 to 6636777
Copr build: https://copr.fedorainfracloud.org/coprs/build/6636777 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248926-rust-jxl-oxide/fedora-rawhide-x86_64/06636777-rust-jxl-oxide/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Thanks, looks good to me! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (test sources are not included in published tarballs) ! latest version of the crate is packaged (with explanation) - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files (temporarily manually included from upstream GitHub project) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-jxl-oxide FEDORA-2023-97fe0ade5c has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-97fe0ade5c FEDORA-2023-97fe0ade5c has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |