Bug 2248952
| Summary: | Review Request: ittapi - Intel Instrumentation and Tracing Technology and Just-In-Time API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ali Erdinc Koroglu <aekoroglu> |
| Component: | Package Review | Assignee: | Simone Caronni <negativo17> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | negativo17, package-review, trix |
| Target Milestone: | --- | Flags: | negativo17:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://github.com/intel/ittapi | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-09-17 15:14:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1011110 | ||
|
Description
Ali Erdinc Koroglu
2023-11-09 20:33:12 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6617109 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248952-ittapi/fedora-rawhide-x86_64/06617109-ittapi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The big issue I have found is the upstream project has binaries checked into its repo. https://github.com/intel/ittapi/blob/master/include/fortran/posix/x86/advisor_annotate.o Everything in fedora must be built from fedora. smaller issues The soversion is defined in the patch, update the patch to match the release new directories need a %dir <new dir> It would be nice to have %check So I can verifiy it works. Hi Ali,
Tom is correct in the above comments, please fix the patch to make the shared object name to have the same version, there's no point in making those different.
The header part in the file list, should either be:
%{_includedir}/*
or:
%{_includedir}/advisor-annotate.h
%{_includedir}/ittnotify-zca.h
%{_includedir}/ittnotify.h
%{_includedir}/jitprofiling.h
%{_includedir}/libittnotify.h
%dir %{_includedir}/legacy
%{_includedir}/legacy/ittnotify.h
I see the binaries are no longer included, very good!
Please fix the headers file list with one of the above before committing, otherwise pacakge approved!
Thanks,
--Simone
The Pagure repository was created at https://src.fedoraproject.org/rpms/ittapi Thank you @negativo17 |