Bug 2248952 - Review Request: ittapi - Intel Instrumentation and Tracing Technology and Just-In-Time API
Summary: Review Request: ittapi - Intel Instrumentation and Tracing Technology and Jus...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Tom Rix
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/intel/ittapi
Whiteboard:
Depends On:
Blocks: ML-SIG
TreeView+ depends on / blocked
 
Reported: 2023-11-09 20:33 UTC by Ali Erdinc Koroglu
Modified: 2023-11-29 19:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
trix: fedora-review?


Attachments (Terms of Use)

Description Ali Erdinc Koroglu 2023-11-09 20:33:12 UTC
SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/06617100-ittapi/ittapi.spec
SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/06617100-ittapi/ittapi-3.24.3-1.fc40.src.rpm

Description:
The Instrumentation and Tracing Technology (ITT) API enables your application
to generate and control the collection of trace data during its execution
across different Intel tools.

Reproducible: Always

Comment 1 Fedora Review Service 2023-11-09 20:40:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6617109
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248952-ittapi/fedora-rawhide-x86_64/06617109-ittapi/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Tom Rix 2023-11-29 19:00:08 UTC
The big issue I have found is the upstream project has binaries checked into its repo.
https://github.com/intel/ittapi/blob/master/include/fortran/posix/x86/advisor_annotate.o
Everything in fedora must be built from fedora.

smaller issues
The soversion is defined in the patch, update the patch to match the release

new directories need a
%dir <new dir>

It would be nice to have 
%check

So I can verifiy it works.


Note You need to log in before you can comment on or make changes to this bug.