Bug 2249211

Summary:	Review Request: rust-cargo-credential-libsecret - Cargo credential process that stores tokens with GNOME libsecret
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Kalev Lember <klember>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	klember, package-review
Target Milestone:	---	Flags:	klember: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/cargo-credential-libsecret
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-11-14 01:58:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2249210
Bug Blocks:	2129110

Description Fabio Valentini 2023-11-11 10:55:38 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-cargo-credential-libsecret.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cargo-credential-libsecret-0.3.1-1.fc39.src.rpm

Description:
A Cargo credential process that stores tokens with GNOME libsecret.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2023-11-11 10:59:21 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6624353
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249211-rust-cargo-credential-libsecret/fedora-rawhide-x86_64/06624353-rust-cargo-credential-libsecret/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Kalev Lember 2023-11-11 18:34:29 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2023-11-13 22:48:28 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-credential-libsecret

Comment 4 Fabio Valentini 2023-11-14 01:58:23 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6f419dc91b