Bug 2249210 - Review Request: rust-cargo-credential - Library to assist writing Cargo credential helpers
Summary: Review Request: rust-cargo-credential - Library to assist writing Cargo crede...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/cargo-creden...
Whiteboard:
Depends On:
Blocks: 2129110 2249211
TreeView+ depends on / blocked
 
Reported: 2023-11-11 10:55 UTC by Fabio Valentini
Modified: 2023-11-14 01:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-11-14 01:58:12 UTC
Type: ---
Embargoed:
klember: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-11-11 10:55:01 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-cargo-credential.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-cargo-credential-0.3.0-1.fc39.src.rpm

Description:
A library to assist writing Cargo credential helpers.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-11-11 10:55:04 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=108893044

Comment 2 Fedora Review Service 2023-11-11 11:04:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6624352
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249210-rust-cargo-credential/fedora-rawhide-x86_64/06624352-rust-cargo-credential/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Kalev Lember 2023-11-11 18:30:09 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

P.S. There's a newer 0.4.0 version available upstream, if you didn't notice - I assume you picked older 0.3.0 deliberately.

Comment 4 Fedora Admin user for bugzilla script actions 2023-11-13 22:45:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-credential

Comment 5 Fabio Valentini 2023-11-14 01:58:12 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-6f419dc91b


Note You need to log in before you can comment on or make changes to this bug.