Bug 2249404

Summary:	Review Request: rust-gtk-blueprint - Use Blueprint in Rust GTK applications
Product:	[Fedora] Fedora	Reporter:	Davide Cavalca <davide>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review?
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/gtk-blueprint
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-10-18 15:50:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Davide Cavalca 2023-11-12 20:42:21 UTC

Spec URL: https://dcavalca.fedorapeople.org/review/rust-gtk-blueprint/rust-gtk-blueprint.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-gtk-blueprint/rust-gtk-blueprint-0.2.0-1.fc40.src.rpm

Description:
Use Blueprint in Rust GTK applications.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-11-12 20:42:54 UTC

I used this rust2rpm.toml:

[requires]
build = ["blueprint-compiler"]
test = ["gtk4-devel"]
lib = ["blueprint-compiler"]

Comment 2 Fedora Review Service 2023-11-12 20:48:57 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6627078
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249404-rust-gtk-blueprint/fedora-rawhide-x86_64/06627078-rust-gtk-blueprint/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2023-11-13 18:17:13 UTC

> license = "GPL-3.0"

This is a deprecated identifier. Its non-deprecated equivalent is "GPL-3.0-only".
It might be good to ask the upstream project about clarifying this (i.e. "GPL-3.0-only" or "GPL-3.0-or-later").

c.f. https://spdx.org/licenses/#deprecated

Comment 4 Davide Cavalca 2023-12-06 22:57:52 UTC

I've submitted https://github.com/Megadash452/gtk-blueprint/pull/1 for that

Comment 5 Fabio Valentini 2024-10-16 19:42:35 UTC

To clarify, it would be fine to fix the license identifier downstream if there were *any* indication in this project whether it should be GPL-3.0-only or GPL-3.0-or-later, but I can't find anything in the code that would support picking either one.

Comment 6 Davide Cavalca 2024-10-18 15:50:35 UTC

I'm going to drop this, ended up using something else and I don't need it anymore.