Bug 2249404 - Review Request: rust-gtk-blueprint - Use Blueprint in Rust GTK applications
Summary: Review Request: rust-gtk-blueprint - Use Blueprint in Rust GTK applications
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/gtk-blueprint
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-11-12 20:42 UTC by Davide Cavalca
Modified: 2023-12-06 22:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review?


Attachments (Terms of Use)

Description Davide Cavalca 2023-11-12 20:42:21 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-gtk-blueprint/rust-gtk-blueprint.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-gtk-blueprint/rust-gtk-blueprint-0.2.0-1.fc40.src.rpm

Description:
Use Blueprint in Rust GTK applications.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2023-11-12 20:42:54 UTC
I used this rust2rpm.toml:

[requires]
build = ["blueprint-compiler"]
test = ["gtk4-devel"]
lib = ["blueprint-compiler"]

Comment 2 Fedora Review Service 2023-11-12 20:48:57 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6627078
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249404-rust-gtk-blueprint/fedora-rawhide-x86_64/06627078-rust-gtk-blueprint/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2023-11-13 18:17:13 UTC
> license = "GPL-3.0"

This is a deprecated identifier. Its non-deprecated equivalent is "GPL-3.0-only".
It might be good to ask the upstream project about clarifying this (i.e. "GPL-3.0-only" or "GPL-3.0-or-later").

c.f. https://spdx.org/licenses/#deprecated

Comment 4 Davide Cavalca 2023-12-06 22:57:52 UTC
I've submitted https://github.com/Megadash452/gtk-blueprint/pull/1 for that


Note You need to log in before you can comment on or make changes to this bug.