Bug 2249878
| Summary: | Review Request: golang-mau-util - Various Go utilities used by mautrix-go and bridges | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kai A. Hiller <V02460> | ||||||
| Component: | Package Review | Assignee: | Mikel Olasagasti Uranga <mikel> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | mikel, package-review | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | mikel:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-04-11 17:06:23 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2250408 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kai A. Hiller
2023-11-15 18:19:42 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6639643 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249878-golang-mau-util/fedora-rawhide-x86_64/06639643-golang-mau-util/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. The code in /base58 is vendored from https://github.com/btcsuite/btcd/tree/master/btcutil/base58 and is under a different license (ISC). Is it necessary to get the whole btcd code into Fedora? Or is a more focused way possible, like specifically adding a golang-github-btcsuite-btcd-btcutil-base58 package? Spec URL: https://v02460.fedorapeople.org/golang-mau-util.spec SRPM URL: https://v02460.fedorapeople.org/golang-mau-util-0.2.1-1.fc40.src.rpm Created attachment 2000828 [details]
The .spec file difference from Copr build 6639643 to 6677283
Copr build: https://copr.fedorainfracloud.org/coprs/build/6677283 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249878-golang-mau-util/fedora-rawhide-x86_64/06677283-golang-mau-util/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://v02460.fedorapeople.org/golang-mau-util.spec SRPM URL: https://v02460.fedorapeople.org/golang-mau-util-0.4.0-1.fc41.src.rpm Created attachment 2021678 [details]
The .spec file difference from Copr build 6677283 to 7160872
Copr build: https://copr.fedorainfracloud.org/coprs/build/7160872 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249878-golang-mau-util/fedora-rawhide-x86_64/07160872-golang-mau-util/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Golang Package Review
==============
This package was generated using go2rpm, which simplifies the review.
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance
Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-mau-util FEDORA-2024-f776a75e38 (golang-mau-util-0.4.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f776a75e38 FEDORA-2024-f776a75e38 (golang-mau-util-0.4.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |