Spec URL: https://v02460.fedorapeople.org/golang-maunium-mautrix.spec SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mautrix-0.16.2-1.fc40.src.rpm Description: A Golang Matrix framework Fedora Account System Username: v02460
Copr build: https://copr.fedorainfracloud.org/coprs/build/6666938 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250408-golang-maunium-mautrix/srpm-builds/06666938/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://v02460.fedorapeople.org/golang-maunium-mautrix.spec SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mautrix-0.16.2-2.fc40.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/6677359 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250408-golang-maunium-mautrix/fedora-rawhide-x86_64/06677359-golang-maunium-mautrix/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://v02460.fedorapeople.org/golang-maunium-mautrix.spec SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mautrix-0.18.1-1.fc41.src.rpm
> Patch1: 0001-Unvendor-crypto-canonicaljson.patch Why do you prefer to patch the package to remove the bundled library? I'm not sure how this benefits the package. > BuildRequires: gcc-c++ > BuildRequires: libolm-devel Where are these required? I can't see in the code or in the spec where they're used.
> > BuildRequires: gcc-c++ > > BuildRequires: libolm-devel > > Where are these required? I can't see in the code or in the spec where > they're used. It’s here: https://github.com/mautrix/go/blob/2810465ef29466b531d3424bd4175fa8f0af4c26/crypto/olm/olm.go#L5
Golang Package Review ============== This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. - [ ] Consider configuring Packit service to help with maintenance Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-maunium-mautrix
FEDORA-2024-90318b414d (golang-maunium-mautrix-0.18.1-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-90318b414d
FEDORA-2024-90318b414d (golang-maunium-mautrix-0.18.1-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.