Bug 2249890

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6639884
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249890-golang-maunium-mauflag/fedora-rawhide-x86_64/06639884-golang-maunium-mauflag/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://v02460.fedorapeople.org/golang-maunium-mauflag.spec
SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mauflag-1.0.0-2.fc40.src.rpm

Created attachment 2000827 [details]
The .spec file difference from Copr build 6639884 to 6677251

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6677251
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249890-golang-maunium-mauflag/fedora-rawhide-x86_64/06677251-golang-maunium-mauflag/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Spec URL: https://v02460.fedorapeople.org/golang-maunium-mauflag.spec
SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mauflag-1.0.0-3.fc41.src.rpm

Created attachment 2021840 [details]
The .spec file difference from Copr build 6677251 to 7165355

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7165355
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249890-golang-maunium-mauflag/fedora-rawhide-x86_64/07165355-golang-maunium-mauflag/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

The `flagtest` binary is described as "flagtest - Test the mauflag packag", is it required?

https://github.com/tulir/mauflag/blob/master/flagtest/flagtest.go#L34C22-L34C56

If not required remove these lines to avoid shipping the binary:

> %build
> for cmd in flagtest; do
>   %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd
> done
> (...)
> install -m 0755 -vd                     %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
> (...)
> %files
> %license LICENSE
> %doc README.md
> %{_bindir}/*

The flagtest binary doesn’t seem to be required. Updated the spec file accordingly :)

Spec URL: https://v02460.fedorapeople.org/golang-maunium-mauflag.spec
SRPM URL: https://v02460.fedorapeople.org/golang-maunium-mauflag-1.0.0-4.fc41.src.rpm

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-maunium-mauflag

FEDORA-2024-4055a58a98 (golang-maunium-mauflag-1.0.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-4055a58a98

FEDORA-2024-4055a58a98 (golang-maunium-mauflag-1.0.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.