Bug 2250445
| Summary: | Review Request: rust-triomphe - Fork of std::sync::Arc with some extra functionality and without weak references | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mattia Verga <mattia.verga> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://crates.io/crates/triomphe | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-11-26 11:15:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2247321 | ||
|
Description
Mattia Verga
2023-11-18 16:43:52 UTC
This will need the unsize crate, but I'm not able to post a review request ATM because looks like licenses are not distribute within the crate. I have no rust skills to fix that and very limited time currently, so if someone else can help with that I'd appreciate that. This is blocking the whole stack rust-unsize, rust-triomphe, rust-archery, rust-rpds, python-rpds-py. Copr build: https://copr.fedorainfracloud.org/coprs/build/6666952 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250445-rust-triomphe/srpm-builds/06666952/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://mattia.fedorapeople.org/triomphe/rust-triomphe.spec SRPM URL: https://mattia.fedorapeople.org/triomphe/rust-triomphe-0.1.9-1.fc40.src.rpm Removed the optional unsize dependency from cargo.toml. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/6670543 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250445-rust-triomphe/fedora-rawhide-x86_64/06670543-rust-triomphe/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === It would be great if you could review one of my pending packages in return (maybe #2251238), if you have the time for it. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-triomphe FEDORA-2023-f0afeb37f8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f0afeb37f8 FEDORA-2023-f0afeb37f8 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |