Bug 2250445 - Review Request: rust-triomphe - Fork of std::sync::Arc with some extra functionality and without weak references
Summary: Review Request: rust-triomphe - Fork of std::sync::Arc with some extra functi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/triomphe
Whiteboard:
Depends On:
Blocks: 2247321
TreeView+ depends on / blocked
 
Reported: 2023-11-18 16:43 UTC by Mattia Verga
Modified: 2023-11-26 11:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-26 11:15:50 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Mattia Verga 2023-11-18 16:43:52 UTC
Spec URL: https://mattia.fedorapeople.org/triomphe/rust-triomphe.spec
SRPM URL: https://mattia.fedorapeople.org/triomphe/rust-triomphe-0.1.9-1.fc40.src.rpm
Description: A fork of std::sync::Arc with some extra functionality and without weak references (originally servo_arc).
Fedora Account System Username: mattia

Comment 1 Mattia Verga 2023-11-18 16:56:49 UTC
This will need the unsize crate, but I'm not able to post a review request ATM because looks like licenses are not distribute within the crate. I have no rust skills to fix that and very limited time currently, so if someone else can help with that I'd appreciate that.

This is blocking the whole stack rust-unsize, rust-triomphe, rust-archery, rust-rpds, python-rpds-py.

Comment 2 Fedora Review Service 2023-11-18 22:30:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6666952
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250445-rust-triomphe/srpm-builds/06666952/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Mattia Verga 2023-11-19 08:26:02 UTC
Spec URL: https://mattia.fedorapeople.org/triomphe/rust-triomphe.spec
SRPM URL: https://mattia.fedorapeople.org/triomphe/rust-triomphe-0.1.9-1.fc40.src.rpm

Removed the optional unsize dependency from cargo.toml.

Comment 4 Mattia Verga 2023-11-20 06:53:07 UTC
[fedora-review-service-build]

Comment 5 Fedora Review Service 2023-11-20 16:37:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6670543
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250445-rust-triomphe/fedora-rawhide-x86_64/06670543-rust-triomphe/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fabio Valentini 2023-11-25 18:26:16 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license files are included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

It would be great if you could review one of my pending packages in return (maybe #2251238), if you have the time for it.

Comment 7 Fedora Admin user for bugzilla script actions 2023-11-26 08:16:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-triomphe

Comment 8 Fedora Update System 2023-11-26 09:23:58 UTC
FEDORA-2023-f0afeb37f8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f0afeb37f8

Comment 9 Fedora Update System 2023-11-26 11:15:50 UTC
FEDORA-2023-f0afeb37f8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.