Bug 2250569

Summary: Review Request: rust-educe - Procedural macros to help you implement Rust-built-in traits quickly
Product: [Fedora] Fedora Reporter: Daiki Ueno <dueno>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 38CC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
URL: https://crates.io/crates/educe
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2023-11-29 23:49:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2250572, 2250574    
Bug Blocks: 2238483    

Description Daiki Ueno 2023-11-19 23:31:09 UTC
Spec file: https://ueno.fedorapeople.org/rust-educe/rust-educe.spec
SRPM: https://ueno.fedorapeople.org/rust-educe/rust-educe-0.4.23-1.fc40.src.rpm
Description:
This crate provides procedural macros to help you implement Rust-built-
in traits quickly.

Reproducible: Always




This is a dependency of tokio-serde (bug 2238483).

Comment 3 Fedora Review Service 2023-11-21 09:32:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6673854
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250569-rust-educe/fedora-rawhide-x86_64/06673854-rust-educe/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2023-11-29 22:11:20 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-29 22:54:56 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-educe

Comment 6 Daiki Ueno 2023-11-29 23:49:14 UTC
Thank you for the review. The package has been imported and built in rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-f9ae403075