Bug 2250574 - Review Request: rust-assert-eq-float - Assert_eq_float! macros that support floats
Summary: Review Request: rust-assert-eq-float - Assert_eq_float! macros that support f...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: 38
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/assert-eq-float
Whiteboard:
Depends On:
Blocks: 2250569
TreeView+ depends on / blocked
 
Reported: 2023-11-20 00:06 UTC by Daiki Ueno
Modified: 2023-11-22 17:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-22 17:01:11 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Daiki Ueno 2023-11-20 00:06:27 UTC
Spec file: https://ueno.fedorapeople.org/rust-assert-eq-float/rust-assert-eq-float.spec
SRPM: https://ueno.fedorapeople.org/rust-assert-eq-float/rust-assert-eq-float-0.1.3-1.fc38.src.rpm
Description:
This crate provides the `assert_eq_float!` macros that support floats.

Reproducible: Always

Comment 1 Fedora Review Service 2023-11-20 16:28:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6670541
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250574-rust-assert-eq-float/srpm-builds/06670541/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fedora Review Service 2023-11-21 00:31:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6671887
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250574-rust-assert-eq-float/fedora-rawhide-x86_64/06671887-rust-assert-eq-float/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2023-11-21 18:16:04 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-22 14:06:00 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-assert-eq-float

Comment 6 Daiki Ueno 2023-11-22 17:01:11 UTC
Thank you for the review. The package has been imported and built in rawhide:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-8b39012490


Note You need to log in before you can comment on or make changes to this bug.