Bug 2250632

Summary: Review Request: golang-github-tdewolff-argp - GNU command line argument parser
Product: [Fedora] Fedora Reporter: Elliott Sales de Andrade <quantum.analyst>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Flags: mikel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-02-27 10:37:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2245375    

Comment 1 Elliott Sales de Andrade 2023-11-20 08:39:54 UTC
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=109289918

Comment 2 Fedora Review Service 2023-11-20 16:27:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6670532
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250632-golang-github-tdewolff-argp/srpm-builds/06670532/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-02-27 09:58:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7064245
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250632-golang-github-tdewolff-argp/fedora-rawhide-x86_64/07064245-golang-github-tdewolff-argp/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Mikel Olasagasti Uranga 2024-02-27 09:59:34 UTC
I am not going to go through the whole fedora-review template, as this package uses go2rpm.

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 6 Elliott Sales de Andrade 2024-02-27 10:05:12 UTC
Thank you for the review, Mikel

Comment 7 Fedora Admin user for bugzilla script actions 2024-02-27 10:05:24 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-tdewolff-argp

Comment 8 Fedora Update System 2024-02-27 10:32:38 UTC
FEDORA-2024-8021b0aca9 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-8021b0aca9

Comment 9 Fedora Update System 2024-02-27 10:37:33 UTC
FEDORA-2024-8021b0aca9 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2024-02-27 11:19:49 UTC
FEDORA-2024-1ef19fb620 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1ef19fb620

Comment 11 Fedora Update System 2024-02-27 11:22:34 UTC
FEDORA-2024-1ef19fb620 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.