Spec URL: https://qulogic.fedorapeople.org/reviews/golang-github-tdewolff-argp/golang-github-tdewolff-argp.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/golang-github-tdewolff-argp/golang-github-tdewolff-argp-0-0.1.20231120gitc81cbda.fc39.src.rpm Description: GNU command line argument parser.
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=109289918
Copr build: https://copr.fedorainfracloud.org/coprs/build/6670532 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250632-golang-github-tdewolff-argp/srpm-builds/06670532/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to latest commit: Spec URL: https://qulogic.fedorapeople.org/reviews/golang-github-tdewolff-argp/golang-github-tdewolff-argp.spec SRPM URL: https://qulogic.fedorapeople.org/reviews/golang-github-tdewolff-argp/golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7064245 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250632-golang-github-tdewolff-argp/fedora-rawhide-x86_64/07064245-golang-github-tdewolff-argp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I am not going to go through the whole fedora-review template, as this package uses go2rpm. - [x] The specfile is sane. - [x] License is correct - [x] Builds successfully in mock - [x] Package is installable (checked by fedora-review) - [x] No relevant rpmlint errors - [x] %check section passes - [x] The latest version is packaged - [x] `%goipath` is set correctly - [-] Binaries don't conflict with binaries already in the distribution - [x] The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Add package to release-monitoring.org - [ ] Give go-sig privileges on package - [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.
Thank you for the review, Mikel
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-tdewolff-argp
FEDORA-2024-8021b0aca9 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8021b0aca9
FEDORA-2024-8021b0aca9 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-1ef19fb620 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1ef19fb620
FEDORA-2024-1ef19fb620 (golang-github-tdewolff-argp-0-0.1.20240227git719bbce.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.