Bug 225100

Summary: initng, initng-ifiles: optflags not used
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: initngAssignee: Daniel Malmgren <dm>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-02-05 10:06:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Honor optflags
none
Use $RPM_OPT_FLAGS - patch for initng none

Description Ville Skyttä 2007-01-28 22:56:44 UTC
initng-ifiles does not honor $RPM_OPT_FLAGS, resulting in no-no such as no stack
protection and semi-useless debuginfo.  Fix attached.

http://fedoraproject.org/wiki/Packaging/Debuginfo

Comment 1 Ville Skyttä 2007-01-28 22:56:45 UTC
Created attachment 146792 [details]
Honor optflags

Comment 2 Daniel Malmgren 2007-01-29 09:01:39 UTC
Hmmm... I guess this means that the same goes for initng, right? I wonder why
nobody noticed that in package review. I'll look into it.


Comment 3 Ville Skyttä 2007-01-29 15:20:29 UTC
Yep, looks like initng is affected as well - its -debuginfo contains only
*.debug files, no sources, which is a sign of -g not being used during
compilation (and thus usually neither the rest of $RPM_OPT_FLAGS).

Comment 4 Ville Skyttä 2007-02-04 18:41:17 UTC
Created attachment 147316 [details]
Use $RPM_OPT_FLAGS - patch for initng

I see a new initng was committed without the CFLAGS being fixed... here's the
fix.

Comment 5 Daniel Malmgren 2007-02-04 18:57:18 UTC
Sorry. Forgot. Committed new version with your fix.

Comment 6 Daniel Malmgren 2007-02-05 10:06:04 UTC
I've now built new versions of both initng and initng-ifiles, using
$RPM_OPT_FLAGS. Closing.