Bug 225100 - initng, initng-ifiles: optflags not used
initng, initng-ifiles: optflags not used
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: initng (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Daniel Malmgren
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-28 17:56 EST by Ville Skyttä
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-05 05:06:04 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Honor optflags (542 bytes, patch)
2007-01-28 17:56 EST, Ville Skyttä
no flags Details | Diff
Use $RPM_OPT_FLAGS - patch for initng (474 bytes, patch)
2007-02-04 13:41 EST, Ville Skyttä
no flags Details | Diff

  None (edit)
Description Ville Skyttä 2007-01-28 17:56:44 EST
initng-ifiles does not honor $RPM_OPT_FLAGS, resulting in no-no such as no stack
protection and semi-useless debuginfo.  Fix attached.

http://fedoraproject.org/wiki/Packaging/Debuginfo
Comment 1 Ville Skyttä 2007-01-28 17:56:45 EST
Created attachment 146792 [details]
Honor optflags
Comment 2 Daniel Malmgren 2007-01-29 04:01:39 EST
Hmmm... I guess this means that the same goes for initng, right? I wonder why
nobody noticed that in package review. I'll look into it.
Comment 3 Ville Skyttä 2007-01-29 10:20:29 EST
Yep, looks like initng is affected as well - its -debuginfo contains only
*.debug files, no sources, which is a sign of -g not being used during
compilation (and thus usually neither the rest of $RPM_OPT_FLAGS).
Comment 4 Ville Skyttä 2007-02-04 13:41:17 EST
Created attachment 147316 [details]
Use $RPM_OPT_FLAGS - patch for initng

I see a new initng was committed without the CFLAGS being fixed... here's the
fix.
Comment 5 Daniel Malmgren 2007-02-04 13:57:18 EST
Sorry. Forgot. Committed new version with your fix.
Comment 6 Daniel Malmgren 2007-02-05 05:06:04 EST
I've now built new versions of both initng and initng-ifiles, using
$RPM_OPT_FLAGS. Closing.

Note You need to log in before you can comment on or make changes to this bug.