Bug 2251275

Summary: Review Request: kactivities - Core components for the KDE Activity concept
Product: [Fedora] Fedora Reporter: Alessandro Astone <ales.astone>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
URL: https://invent.kde.org/plasma/%{name}
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-01-31 21:58:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Alessandro Astone 2023-11-23 19:25:08 UTC 
Spec URL: https://aleasto.fedorapeople.org/reviews/kactivities/kactivities.spec
SRPM URL: https://aleasto.fedorapeople.org/reviews/kactivities/kactivities-5.27.80-1.fc40.src.rpm
Description: Core components for the KDE Activity concept
Fedora Account System Username: aleasto
Comment 1 Fedora Review Service 2023-11-23 19:30:55 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6685697
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251275-kactivities/fedora-rawhide-x86_64/06685697-kactivities/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Neal Gompa 2023-11-24 13:02:33 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines (with one exception)
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note, please fix the glob for the library on import, it's too greedy. (Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files)

PACKAGE APPROVED.