Bug 2251275 - Review Request: kactivities - Core components for the KDE Activity concept
Summary: Review Request: kactivities - Core components for the KDE Activity concept
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/plasma/%{name}
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-11-23 19:25 UTC by Alessandro Astone
Modified: 2024-01-31 21:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-31 21:58:31 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Alessandro Astone 2023-11-23 19:25:08 UTC
Spec URL: https://aleasto.fedorapeople.org/reviews/kactivities/kactivities.spec
SRPM URL: https://aleasto.fedorapeople.org/reviews/kactivities/kactivities-5.27.80-1.fc40.src.rpm
Description: Core components for the KDE Activity concept
Fedora Account System Username: aleasto

Comment 1 Fedora Review Service 2023-11-23 19:30:55 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6685697
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251275-kactivities/fedora-rawhide-x86_64/06685697-kactivities/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2023-11-24 13:02:33 UTC
Review notes:

* Package follows Fedora Packaging Guidelines (with one exception)
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note, please fix the glob for the library on import, it's too greedy. (Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files)

PACKAGE APPROVED.


Note You need to log in before you can comment on or make changes to this bug.