Bug 2251553

Summary:	Review Request: perl-Test-ExpectAndCheck - Expect/check-style unit testing with object methods
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Michal Josef Spacek <mspacek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mspacek, package-review
Target Milestone:	---	Flags:	mspacek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Test-ExpectAndCheck-0.06-2.fc40	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-02-02 09:56:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2244881

Description Emmanuel Seyman 2023-11-26 10:33:28 UTC

Spec URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck.spec
SRPM URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck-0.06-1.fc38.src.rpm
Description:
This package creates objects that assist in writing unit tests with mocked
object instances. Each mock instance will expect to receive a given list of
method calls. Each method call is checked that it received the right
arguments, and will return a prescribed result. At the end of each test,
each object is checked to ensure all the expected methods were called.

Fedora Account System Username: eseyman

Comment 1 Michal Josef Spacek 2024-01-22 11:21:49 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-ExpectAndCheck-0.06-1.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl-libs
      1 perl(List::Util)
      1 perl(Scalar::Util)
      1 perl(Test::Deep)
      1 perl(Test::ExpectAndCheck)
      1 perl(Test::ExpectAndCheck::_Expectation)
      1 perl(Test::Future::Deferred)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)

Require to Test::ExpectAndCheck::_Expectation isn't ok, this is internal and it's not provided by packages.

$ rpm -qp --provides perl-Test-ExpectAndCheck-0.06-1.fc40.noarch.rpm | sort | uniq -c
      1 perl(Test::ExpectAndCheck::Future) = 0.06
      1 perl(Test::ExpectAndCheck) = 0.06
      1 perl-Test-ExpectAndCheck = 0.06-1.fc40
Binary provides are Ok.

$ rpmlint perl-Test-ExpectAndCheck*
2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness
Rpmlint is ok

Resolution:
We need fix require.

Comment 2 Emmanuel Seyman 2024-01-22 17:54:05 UTC

(In reply to Michal Josef Spacek from comment #1)
>
> Resolution:
> We need fix require.

Indeed. I've updated the spec file.

Spec URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck.spec
SRPM URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck-0.06-2.fc38.src.rpm

Comment 3 Michal Josef Spacek 2024-01-31 08:57:24 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Test-ExpectAndCheck-0.06-2.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl-libs
      1 perl(List::Util)
      1 perl(Scalar::Util)
      1 perl(Test::Deep)
      1 perl(Test::ExpectAndCheck)
      1 perl(Test::Future::Deferred)
      1 perl(:VERSION) >= 5.14.0
      1 perl(warnings)

$ rpm -qp --provides perl-Test-ExpectAndCheck-0.06-2.fc40.noarch.rpm | sort | uniq -c
      1 perl(Test::ExpectAndCheck::Future) = 0.06
      1 perl(Test::ExpectAndCheck) = 0.06
      1 perl-Test-ExpectAndCheck = 0.06-2.fc40
Binary provides are Ok.

$ rpmlint perl-Test-ExpectAndCheck*
2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness
Rpmlint is ok

Resolution:
Everything is ok

Comment 4 Emmanuel Seyman 2024-01-31 22:26:09 UTC

Thank you for the review, Michal.

Can you set the fedora-review flag to '+'? This is needed for repo creation.

Comment 5 Michal Josef Spacek 2024-02-01 14:04:31 UTC

Flag added, sorry.

Comment 6 Fedora Admin user for bugzilla script actions 2024-02-01 18:19:21 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-ExpectAndCheck

Comment 7 Emmanuel Seyman 2024-02-02 09:56:17 UTC

(In reply to Michal Josef Spacek from comment #5)
>
> Flag added, sorry.

No problem. :-)

Package imported and built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2397020