Spec URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck-0.06-1.fc38.src.rpm Description: This package creates objects that assist in writing unit tests with mocked object instances. Each mock instance will expect to receive a given list of method calls. Each method call is checked that it received the right arguments, and will return a prescribed result. At the end of each test, each object is checked to ensure all the expected methods were called. Fedora Account System Username: eseyman
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Test-ExpectAndCheck-0.06-1.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl-libs 1 perl(List::Util) 1 perl(Scalar::Util) 1 perl(Test::Deep) 1 perl(Test::ExpectAndCheck) 1 perl(Test::ExpectAndCheck::_Expectation) 1 perl(Test::Future::Deferred) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) Require to Test::ExpectAndCheck::_Expectation isn't ok, this is internal and it's not provided by packages. $ rpm -qp --provides perl-Test-ExpectAndCheck-0.06-1.fc40.noarch.rpm | sort | uniq -c 1 perl(Test::ExpectAndCheck::Future) = 0.06 1 perl(Test::ExpectAndCheck) = 0.06 1 perl-Test-ExpectAndCheck = 0.06-1.fc40 Binary provides are Ok. $ rpmlint perl-Test-ExpectAndCheck* 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness Rpmlint is ok Resolution: We need fix require.
(In reply to Michal Josef Spacek from comment #1) > > Resolution: > We need fix require. Indeed. I've updated the spec file. Spec URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck.spec SRPM URL: https://eseyman.fedorapeople.org/perl-Test-ExpectAndCheck/perl-Test-ExpectAndCheck-0.06-2.fc38.src.rpm
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Test-ExpectAndCheck-0.06-2.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Carp) 1 perl(constant) 1 perl-libs 1 perl(List::Util) 1 perl(Scalar::Util) 1 perl(Test::Deep) 1 perl(Test::ExpectAndCheck) 1 perl(Test::Future::Deferred) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) $ rpm -qp --provides perl-Test-ExpectAndCheck-0.06-2.fc40.noarch.rpm | sort | uniq -c 1 perl(Test::ExpectAndCheck::Future) = 0.06 1 perl(Test::ExpectAndCheck) = 0.06 1 perl-Test-ExpectAndCheck = 0.06-2.fc40 Binary provides are Ok. $ rpmlint perl-Test-ExpectAndCheck* 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 8 filtered, 0 badness Rpmlint is ok Resolution: Everything is ok
Thank you for the review, Michal. Can you set the fedora-review flag to '+'? This is needed for repo creation.
Flag added, sorry.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-ExpectAndCheck
(In reply to Michal Josef Spacek from comment #5) > > Flag added, sorry. No problem. :-) Package imported and built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=2397020