Bug 2252608
| Summary: | Review Request: python-archspec - A library to query system architecture | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/archspec/archspec | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2023-12-03 15:36:50 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2025802 | ||
|
Description
Orion Poplawski
2023-12-03 00:02:40 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/6717288 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252608-python-archspec/fedora-rawhide-x86_64/06717288-python-archspec/fedora-review/review.txt Found issues: - License file LICENSE-APACHE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. + package name is OK + license is acceptable for Fedora (Apache-2.0 OR MIT) + license is in SPDX + license is specified correctly + R/P/BR look OK (%generate_buildrequires is used) + %check is present + package builds and installs OK No rpmautospec? Why, oh, why? rpmlint says: python3-archspec.noarch: W: no-manual-page-for-binary archspec python3-archspec.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/archspec/json/.git python3-archspec.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/archspec/json/.github python3-archspec.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/archspec/json/.github Please remove .git and .github. This is a standard template-based python package, everything looks normal. Package is APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/python-archspec (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > + package name is OK > + license is acceptable for Fedora (Apache-2.0 OR MIT) > + license is in SPDX > + license is specified correctly > + R/P/BR look OK (%generate_buildrequires is used) > + %check is present > + package builds and installs OK > > No rpmautospec? Why, oh, why? I spend most of my time on EL8 and rpmautospec is a pain there. Also, I'm old and set in my ways. :) > rpmlint says: > python3-archspec.noarch: W: no-manual-page-for-binary archspec > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.git > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.github > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.github > > Please remove .git and .github. Thanks, removed. > This is a standard template-based python package, everything looks normal. > Package is APPROVED. Thanks for the review. Checked in and built. |