Spec URL: https://orion.fedorapeople.org/python-archspec.spec SRPM URL: https://orion.fedorapeople.org/python-archspec-0.2.2-1.fc40.src.rpm Description: Archspec aims at providing a standard set of human-understandable labels for various aspects of a system architecture like CPU, network fabrics, etc. and APIs to detect, query and compare them. This project grew out of Spack and is currently under active development. At present it supports APIs to detect and model compatibility relationships among different CPU microarchitectures. Fedora Account System Username: orion
Copr build: https://copr.fedorainfracloud.org/coprs/build/6717288 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252608-python-archspec/fedora-rawhide-x86_64/06717288-python-archspec/fedora-review/review.txt Found issues: - License file LICENSE-APACHE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
+ package name is OK + license is acceptable for Fedora (Apache-2.0 OR MIT) + license is in SPDX + license is specified correctly + R/P/BR look OK (%generate_buildrequires is used) + %check is present + package builds and installs OK No rpmautospec? Why, oh, why? rpmlint says: python3-archspec.noarch: W: no-manual-page-for-binary archspec python3-archspec.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/archspec/json/.git python3-archspec.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/archspec/json/.github python3-archspec.noarch: W: hidden-file-or-dir /usr/lib/python3.12/site-packages/archspec/json/.github Please remove .git and .github. This is a standard template-based python package, everything looks normal. Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-archspec
(In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > + package name is OK > + license is acceptable for Fedora (Apache-2.0 OR MIT) > + license is in SPDX > + license is specified correctly > + R/P/BR look OK (%generate_buildrequires is used) > + %check is present > + package builds and installs OK > > No rpmautospec? Why, oh, why? I spend most of my time on EL8 and rpmautospec is a pain there. Also, I'm old and set in my ways. :) > rpmlint says: > python3-archspec.noarch: W: no-manual-page-for-binary archspec > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.git > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.github > python3-archspec.noarch: W: hidden-file-or-dir > /usr/lib/python3.12/site-packages/archspec/json/.github > > Please remove .git and .github. Thanks, removed. > This is a standard template-based python package, everything looks normal. > Package is APPROVED. Thanks for the review. Checked in and built.