Bug 2253363

In addition to the procedure described above, this package can also be reviewed with this command:

fedora-review --copr-build 6976867 -m fedora-rawhide-x86_64

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* MIT License", "MIT
     License", "*No copyright* Boost Software License 1.0", "zlib License".
     595 files have unknown license. Detailed output of licensecheck in
     /home/fedora/2253363-coin-or-HiGHS/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[ ]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib64/cmake, /usr/lib64/pkgconfig,
     /usr/lib64/python3.12/site-packages, /usr/lib64/python3.12
[x]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 7207 bytes in 3 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: coin-or-HiGHS-1.6.0-1.fc41.aarch64.rpm
          coin-or-HiGHS-devel-1.6.0-1.fc41.aarch64.rpm
          python3-highspy-1.6.0-1.fc41.aarch64.rpm
          coin-or-HiGHS-debuginfo-1.6.0-1.fc41.aarch64.rpm
          coin-or-HiGHS-debugsource-1.6.0-1.fc41.aarch64.rpm
          coin-or-HiGHS-1.6.0-1.fc41.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpgy5bp_k8')]
checks: 32, packages: 6

coin-or-HiGHS.spec:44: W: unversioned-explicit-provides bundled(FilereaderLP)
coin-or-HiGHS.aarch64: W: no-manual-page-for-binary highs
coin-or-HiGHS-devel.aarch64: W: no-documentation
python3-highspy.aarch64: W: no-documentation
 6 packages and 0 specfiles checked; 0 errors, 4 warnings, 43 filtered, 0 badness; has taken 2.2 s 




Rpmlint (debuginfo)
-------------------
Checking: coin-or-HiGHS-debuginfo-1.6.0-1.fc41.aarch64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp02ib1eot')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 11 filtered, 0 badness; has taken 0.6 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 5

coin-or-HiGHS.aarch64: W: no-manual-page-for-binary highs
coin-or-HiGHS-devel.aarch64: W: no-documentation
python3-highspy.aarch64: W: no-documentation
 5 packages and 0 specfiles checked; 0 errors, 3 warnings, 41 filtered, 0 badness; has taken 1.8 s 



Unversioned so-files
--------------------
python3-highspy: /usr/lib64/python3.12/site-packages/highspy.cpython-312-aarch64-linux-gnu.so

Source checksums
----------------
https://github.com/ERGO-Code/HiGHS/archive/v1.6.0/HiGHS-1.6.0.tar.gz :
  CHECKSUM(SHA256) this package     : 71962981566477c72c51b8b722c5df053d857b05b4f0e6869f455f657b3aa193
  CHECKSUM(SHA256) upstream package : 71962981566477c72c51b8b722c5df053d857b05b4f0e6869f455f657b3aa193


Requires
--------
coin-or-HiGHS (rpmlib, GLIBC filtered):
    ld-linux-aarch64.so.1()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhighs.so.1.6()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.7)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libz.so.1()(64bit)
    rtld(GNU_HASH)

coin-or-HiGHS-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    cmake-filesystem(aarch-64)
    coin-or-HiGHS(aarch-64)
    libhighs.so.1.6()(64bit)
    zlib-devel(aarch-64)

python3-highspy (rpmlib, GLIBC filtered):
    coin-or-HiGHS(aarch-64)
    ld-linux-aarch64.so.1()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libhighs.so.1.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.11)(64bit)
    libstdc++.so.6(CXXABI_1.3.13)(64bit)
    libstdc++.so.6(CXXABI_1.3.15)(64bit)
    libstdc++.so.6(CXXABI_1.3.2)(64bit)
    libstdc++.so.6(CXXABI_1.3.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    python(abi)
    python3.12dist(numpy)
    rtld(GNU_HASH)

coin-or-HiGHS-debuginfo (rpmlib, GLIBC filtered):

coin-or-HiGHS-debugsource (rpmlib, GLIBC filtered):



Provides
--------
coin-or-HiGHS:
    bundled(FilereaderLP)
    coin-or-HiGHS
    coin-or-HiGHS(aarch-64)
    libhighs.so.1.6()(64bit)

coin-or-HiGHS-devel:
    cmake(highs)
    coin-or-HiGHS-devel
    coin-or-HiGHS-devel(aarch-64)
    pkgconfig(highs)

python3-highspy:
    python-highspy
    python3-highspy
    python3-highspy(aarch-64)
    python3.12-highspy
    python3.12dist(highspy)
    python3dist(highspy)

coin-or-HiGHS-debuginfo:
    coin-or-HiGHS-debuginfo
    coin-or-HiGHS-debuginfo(aarch-64)
    debuginfo(build-id)
    libhighs.so.1.6.0-1.6.0-1.fc41.aarch64.debug()(64bit)

coin-or-HiGHS-debugsource:
    coin-or-HiGHS-debugsource
    coin-or-HiGHS-debugsource(aarch-64)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2253363
Buildroot used: fedora-rawhide-aarch64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Python, fonts, R, PHP, SugarActivity, Java, Haskell, Ocaml, Perl
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) Builds on all architectures https://koji.fedoraproject.org/koji/taskinfo?taskID=113847080
b) Known bug on directory ownership https://bugzilla.redhat.com/show_bug.cgi?id=2264345
c) Should patches for:
# Check availability of the popcount instruction at runtime
# Fix out-of-bounds vector accesses
be upstreamed?
d) There seems to be a bug concurrently building Fortran interfaces:
https://github.com/ERGO-Code/HiGHS/issues/1614
e) Approved.

Thank you very much for the review.

(In reply to Benson Muite from comment #2)
> Comments:
> a) Builds on all architectures
> https://koji.fedoraproject.org/koji/taskinfo?taskID=113847080
> b) Known bug on directory ownership
> https://bugzilla.redhat.com/show_bug.cgi?id=2264345
> c) Should patches for:
> # Check availability of the popcount instruction at runtime
> # Fix out-of-bounds vector accesses
> be upstreamed?

I can propose the popcount instruction change, but it only works with gcc or clang.  A different approach would be needed for other compilers (e.g., for Windows).  The out-of-bounds vector access patch should be upstreamed, but I'm still unsure if this is the right fix.  I'll try submitting it upstream and see what they think.  More concretely, I need to come up with a small test case that exhibits the problem.  (It showed up while building mp.)

> d) There seems to be a bug concurrently building Fortran interfaces:
> https://github.com/ERGO-Code/HiGHS/issues/1614

Interesting.  Okay, I will keep an eye on that issue.  Thanks for pointing it out.

Maybe raise an issue for the out of bounds vector access? If upstream does find a better way to fix it,
then on would know not to apply the patch.

The Pagure repository was created at https://src.fedoraproject.org/rpms/coin-or-HiGHS

FEDORA-2024-a03add8825 (asl-20240106-1.20240201git2f5d9de.fc41, bliss-0.77-8.fc41, and 35 more) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a03add8825

FEDORA-2024-a03add8825 (asl-20240106-1.20240201git2f5d9de.fc41, bliss-0.77-8.fc41, and 35 more) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.